Skip to content

Revert "[BugFix] Support setting tp=1 for the Eagle draft model to ta…#5903

Merged
wangxiyuan merged 1 commit intovllm-project:mainfrom
zhaomingyu13:main
Jan 14, 2026
Merged

Revert "[BugFix] Support setting tp=1 for the Eagle draft model to ta…#5903
wangxiyuan merged 1 commit intovllm-project:mainfrom
zhaomingyu13:main

Conversation

@zhaomingyu13
Copy link
Copy Markdown
Contributor

@zhaomingyu13 zhaomingyu13 commented Jan 14, 2026

…ke effect (#5519)"

This reverts commit d886b81.

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

…ke effect (#5519)"

This reverts commit d886b81.

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts a previous commit that added support for setting tp=1 for the Eagle draft model. While most of the changes correctly remove the related logic and test cases, there appears to be a critical issue in vllm_ascend/worker/model_runner_v1.py. The revert removes necessary handling for UniformTypeKVCacheSpecs, which could lead to runtime errors. It's likely that this part of the original commit was a separate bug fix and should not be reverted.

Comment on lines +2702 to +2705
if isinstance(kv_cache_group.kv_cache_spec,
EncoderOnlyAttentionSpec):
continue
elif isinstance(kv_cache_spec, AttentionSpec):
elif isinstance(kv_cache_group.kv_cache_spec, AttentionSpec):
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This part of the revert seems to have incorrectly removed the handling for UniformTypeKVCacheSpecs. Without this logic, if a kv_cache_group.kv_cache_spec is an instance of UniformTypeKVCacheSpecs, it will not be processed in this loop, leading to missing entries in kernel_block_sizes. This will likely cause errors later on.

Additionally, the list comprehension for block_sizes on line 2687 will raise an AttributeError because UniformTypeKVCacheSpecs does not have a block_size attribute.

It seems this part of the original commit was a necessary fix and should not be reverted. Please consider restoring the logic for handling UniformTypeKVCacheSpecs.

            kv_cache_spec = kv_cache_group.kv_cache_spec
            if isinstance(kv_cache_spec, UniformTypeKVCacheSpecs):
                # All layers in the UniformTypeKVCacheSpecs have the same type,
                # Pick an arbitrary one to dispatch.
                kv_cache_spec = next(
                    iter(kv_cache_spec.kv_cache_specs.values()))
            if isinstance(kv_cache_spec, EncoderOnlyAttentionSpec):
                continue
            elif isinstance(kv_cache_spec, AttentionSpec):

@wangxiyuan wangxiyuan merged commit d450ba2 into vllm-project:main Jan 14, 2026
14 checks passed
aipaes pushed a commit to aipaes/vllm-ascend that referenced this pull request Jan 15, 2026
…ke effect (vllm-project#5903)

This reverts commit d886b81

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
starmountain1997 pushed a commit to starmountain1997/vllm-ascend that referenced this pull request Jan 31, 2026
…ke effect (vllm-project#5903)

This reverts commit d886b81

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
starmountain1997 pushed a commit to starmountain1997/vllm-ascend that referenced this pull request Jan 31, 2026
…ke effect (vllm-project#5903)

This reverts commit d886b81

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Feb 28, 2026
…ke effect (vllm-project#5903)

This reverts commit d886b81

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
maoxx241 pushed a commit to maoxx241/vllm-ascend that referenced this pull request Mar 2, 2026
…ke effect (vllm-project#5903)

This reverts commit d886b81

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Mar 4, 2026
…ke effect (vllm-project#5903)

This reverts commit d886b81

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
LCAIZJ pushed a commit to LCAIZJ/vllm-ascend that referenced this pull request Mar 7, 2026
…ke effect (vllm-project#5903)

This reverts commit d886b81

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
LCAIZJ pushed a commit to LCAIZJ/vllm-ascend that referenced this pull request Mar 9, 2026
…ke effect (vllm-project#5903)

This reverts commit d886b81

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
LCAIZJ pushed a commit to LCAIZJ/vllm-ascend that referenced this pull request Mar 9, 2026
…ke effect (vllm-project#5903)

This reverts commit d886b81

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
LCAIZJ pushed a commit to LCAIZJ/vllm-ascend that referenced this pull request Mar 10, 2026
…ke effect (vllm-project#5903)

This reverts commit d886b81

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
LCAIZJ pushed a commit to LCAIZJ/vllm-ascend that referenced this pull request Mar 30, 2026
…ke effect (vllm-project#5903)

This reverts commit d886b81

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants