Skip to content

Revert "[BugFix] Support setting tp=1 for the Eagle draft model to ta…#5902

Merged
wangxiyuan merged 1 commit intovllm-project:mainfrom
zhaomingyu13:releases
Jan 14, 2026
Merged

Revert "[BugFix] Support setting tp=1 for the Eagle draft model to ta…#5902
wangxiyuan merged 1 commit intovllm-project:mainfrom
zhaomingyu13:releases

Conversation

@zhaomingyu13
Copy link
Copy Markdown
Contributor

@zhaomingyu13 zhaomingyu13 commented Jan 14, 2026

…ke effect (#5519)"

This reverts commit d886b81.

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully reverts the changes introduced by commit d886b81971f85efcda053e95daa58619f9b1769b. The changes correctly remove the draft_tensor_parallel_size parameter from various test functions and their corresponding speculative_config dictionaries. Additionally, the specific logic for handling tp=1 for the Eagle draft model, including the tp_group_context and its helper function, has been removed from vllm_ascend/spec_decode/eagle_proposer.py and vllm_ascend/worker/model_runner_v1.py. Associated unused imports and minor code simplifications are also part of this revert. The revert appears to be complete and correctly implemented, restoring the codebase to its state before the original bug fix attempt.

…ke effect (#5519)"

This reverts commit d886b81.

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
@wangxiyuan wangxiyuan merged commit 01805fb into vllm-project:main Jan 14, 2026
16 checks passed
aipaes pushed a commit to aipaes/vllm-ascend that referenced this pull request Jan 15, 2026
…ke effect (vllm-project#5519)"(vllm-project#5902)

This reverts commit d886b81. it breaks pd function

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
starmountain1997 pushed a commit to starmountain1997/vllm-ascend that referenced this pull request Jan 31, 2026
…ke effect (vllm-project#5519)"(vllm-project#5902)

This reverts commit d886b81. it breaks pd function

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
starmountain1997 pushed a commit to starmountain1997/vllm-ascend that referenced this pull request Jan 31, 2026
…ke effect (vllm-project#5519)"(vllm-project#5902)

This reverts commit d886b81. it breaks pd function

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Feb 28, 2026
…ke effect (vllm-project#5519)"(vllm-project#5902)

This reverts commit d886b81. it breaks pd function

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
maoxx241 pushed a commit to maoxx241/vllm-ascend that referenced this pull request Mar 2, 2026
…ke effect (vllm-project#5519)"(vllm-project#5902)

This reverts commit d886b81. it breaks pd function

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Mar 4, 2026
…ke effect (vllm-project#5519)"(vllm-project#5902)

This reverts commit d886b81. it breaks pd function

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
LCAIZJ pushed a commit to LCAIZJ/vllm-ascend that referenced this pull request Mar 7, 2026
…ke effect (vllm-project#5519)"(vllm-project#5902)

This reverts commit d886b81. it breaks pd function

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@bde38c1

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants