Revert "[BugFix] Support setting tp=1 for the Eagle draft model to ta…#5902
Revert "[BugFix] Support setting tp=1 for the Eagle draft model to ta…#5902wangxiyuan merged 1 commit intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Code Review
This pull request successfully reverts the changes introduced by commit d886b81971f85efcda053e95daa58619f9b1769b. The changes correctly remove the draft_tensor_parallel_size parameter from various test functions and their corresponding speculative_config dictionaries. Additionally, the specific logic for handling tp=1 for the Eagle draft model, including the tp_group_context and its helper function, has been removed from vllm_ascend/spec_decode/eagle_proposer.py and vllm_ascend/worker/model_runner_v1.py. Associated unused imports and minor code simplifications are also part of this revert. The revert appears to be complete and correctly implemented, restoring the codebase to its state before the original bug fix attempt.
3ad0901 to
48b8dd2
Compare
…ke effect (vllm-project#5519)"(vllm-project#5902) This reverts commit d886b81. it breaks pd function - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@bde38c1 Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
…ke effect (vllm-project#5519)"(vllm-project#5902) This reverts commit d886b81. it breaks pd function - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@bde38c1 Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
…ke effect (vllm-project#5519)"(vllm-project#5902) This reverts commit d886b81. it breaks pd function - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@bde38c1 Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
…ke effect (vllm-project#5519)"(vllm-project#5902) This reverts commit d886b81. it breaks pd function - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@bde38c1 Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
…ke effect (vllm-project#5519)"(vllm-project#5902) This reverts commit d886b81. it breaks pd function - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@bde38c1 Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
…ke effect (vllm-project#5519)"(vllm-project#5902) This reverts commit d886b81. it breaks pd function - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@bde38c1 Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
…ke effect (vllm-project#5519)"(vllm-project#5902) This reverts commit d886b81. it breaks pd function - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@bde38c1 Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
…ke effect (#5519)"
This reverts commit d886b81.
What this PR does / why we need it?
Does this PR introduce any user-facing change?
How was this patch tested?