[0.13.0]enable ep32 for dispatch_ffn_combine#5788
Merged
wangxiyuan merged 3 commits intovllm-project:releases/v0.13.0from Jan 13, 2026
Merged
[0.13.0]enable ep32 for dispatch_ffn_combine#5788wangxiyuan merged 3 commits intovllm-project:releases/v0.13.0from
wangxiyuan merged 3 commits intovllm-project:releases/v0.13.0from
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request increases the supported expert parallelism (EP) size for dispatch_ffn_combine from 16 to 32. The change is straightforward. My review focuses on improving maintainability by replacing the magic number with a named constant. Additionally, please note that the TODO comment on line 244 and a comment in vllm_ascend/envs.py (line 126) appear to be outdated due to this change and would benefit from being updated.
Signed-off-by: lhchg <lhao_cheng@163.com>
Signed-off-by: lhchg <lhao_cheng@163.com>
Signed-off-by: lhchg <lhao_cheng@163.com>
d7dedab to
bbd1d8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
To support dispatch_ffn_combine ep32 enabled
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
Single operator tested