Skip to content

[0.13.0]enable ep32 for dispatch_ffn_combine#5788

Merged
wangxiyuan merged 3 commits intovllm-project:releases/v0.13.0from
lhchg:release_0130_ep32
Jan 13, 2026
Merged

[0.13.0]enable ep32 for dispatch_ffn_combine#5788
wangxiyuan merged 3 commits intovllm-project:releases/v0.13.0from
lhchg:release_0130_ep32

Conversation

@lhchg
Copy link
Copy Markdown
Contributor

@lhchg lhchg commented Jan 12, 2026

What this PR does / why we need it?

To support dispatch_ffn_combine ep32 enabled

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

Single operator tested

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the supported expert parallelism (EP) size for dispatch_ffn_combine from 16 to 32. The change is straightforward. My review focuses on improving maintainability by replacing the magic number with a named constant. Additionally, please note that the TODO comment on line 244 and a comment in vllm_ascend/envs.py (line 126) appear to be outdated due to this change and would benefit from being updated.

Comment thread vllm_ascend/ascend_forward_context.py
@wangxiyuan wangxiyuan changed the title enable ep32 for dispatch_ffn_combine [0.13.0]enable ep32 for dispatch_ffn_combine Jan 12, 2026
lhchg added 3 commits January 12, 2026 16:43
Signed-off-by: lhchg <lhao_cheng@163.com>
Signed-off-by: lhchg <lhao_cheng@163.com>
Signed-off-by: lhchg <lhao_cheng@163.com>
@lhchg lhchg force-pushed the release_0130_ep32 branch from d7dedab to bbd1d8e Compare January 12, 2026 08:44
@wangxiyuan wangxiyuan added ready read for review ready-for-test start test by label for PR labels Jan 13, 2026
@wangxiyuan wangxiyuan merged commit b143822 into vllm-project:releases/v0.13.0 Jan 13, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants