Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ async def test_models(model: str) -> None:
"--gpu-memory-utilization",
"0.65",
"--compilation-config",
'{"cudagraph_capture_sizes": [32], "cudagraph_mode":"FULL_DECODE_ONLY"}',
'{"cudagraph_capture_sizes": [32]}',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While disabling FULL_DECODE_ONLY mode is a valid temporary fix for the accuracy issue, the reason for this change is not apparent from the code alone. To improve maintainability and prevent future regressions, it's crucial to add a comment explaining that this is a temporary workaround. This will provide context for other developers who might work on this test in the future and prevent them from re-enabling it without understanding the implications.

Suggested change
'{"cudagraph_capture_sizes": [32]}',
'{"cudagraph_capture_sizes": [32]}', # TODO: Re-enable 'cudagraph_mode: "FULL_DECODE_ONLY"' once accuracy issue is resolved.

]
request_keyword_args: dict[str, Any] = {
**api_keyword_args,
Expand Down
Loading