Skip to content

[Model][Docs] Support Qwen3-VL-Embedding & Qwen3-VL-Reranker#5741

Closed
gcanlin wants to merge 4 commits intovllm-project:mainfrom
gcanlin:vl-embedding
Closed

[Model][Docs] Support Qwen3-VL-Embedding & Qwen3-VL-Reranker#5741
gcanlin wants to merge 4 commits intovllm-project:mainfrom
gcanlin:vl-embedding

Conversation

@gcanlin
Copy link
Copy Markdown
Collaborator

@gcanlin gcanlin commented Jan 8, 2026

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for Qwen3-VL-Embedding and updates the supported models list. However, the new documentation file contains several inconsistencies and placeholder content that need to be addressed. Specifically, there are errors in the document title, model names used in command examples, and a TODO for performance results. Furthermore, the supported models matrix introduces a broken link to documentation for Qwen3-VL-Reranker, as the file is not included in this PR. These issues should be resolved to ensure the documentation is accurate and complete.

Comment thread docs/source/tutorials/Qwen3_vl_embedding.md Outdated
Comment thread docs/source/tutorials/Qwen3_vl_embedding.md Outdated
Comment thread docs/source/tutorials/Qwen3_vl_embedding.md Outdated
Comment thread docs/source/tutorials/Qwen3_vl_embedding.md Outdated
Comment thread docs/source/user_guide/support_matrix/supported_models.md
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 8, 2026

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@gcanlin
Copy link
Copy Markdown
Collaborator Author

gcanlin commented Jan 9, 2026

Waiting for upgrading to vllm-project/vllm#31890. Otherwise we can't run the Qwen3-VL-Reranker with hf_overrides.

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@gcanlin gcanlin closed this Jan 20, 2026
@gcanlin
Copy link
Copy Markdown
Collaborator Author

gcanlin commented Jan 20, 2026

Open new PR #6034.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation merge-conflicts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant