[bugfix](pcp) expand max_num_tokens for pcp pad#5478
Merged
zzzzwwjj merged 1 commit intovllm-project:mainfrom Jan 4, 2026
Merged
[bugfix](pcp) expand max_num_tokens for pcp pad#5478zzzzwwjj merged 1 commit intovllm-project:mainfrom
zzzzwwjj merged 1 commit intovllm-project:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a temporary workaround to adjust buffer sizes for Prefill Context Parallelism (PCP) by modifying max_num_batched_tokens before calling the parent constructor. While this approach is functional, it is not robust against exceptions that may occur during initialization. My review includes a suggestion to use a try...finally block to ensure the configuration is always restored to its original state, thereby improving the code's resilience and maintainability.
Contributor
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
pisceskkk
force-pushed
the
bugfix_maxtokens
branch
3 times, most recently
from
c5a4d86 to
164cdb9
Compare
zzzzwwjj
reviewed
Dec 30, 2025
pisceskkk
force-pushed
the
bugfix_maxtokens
branch
2 times, most recently
from
db45fc8 to
bbae1f8
Compare
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: QiuChunshuo <qiuchunshuo@huawei.com>
pisceskkk
force-pushed
the
bugfix_maxtokens
branch
from
bbae1f8 to
4e21ea9
Compare
weiguihua2
added
ready
zzzzwwjj
approved these changes
Jan 4, 2026
Rozwel-dx
pushed a commit
to Rozwel-dx/vllm-ascend
that referenced
this pull request
Jan 8, 2026
### What this PR does / why we need it? Since the [PR](vllm-project/vllm#28988) for PCP modifications to `GPUModelRunner` has not yet been merged into vLLM, this PR temporarily requires adjustments to certain buffer sizes. These changes can be reverted once the original [PR](vllm-project/vllm#28988) is merged. ### Does this PR introduce _any_ user-facing change? No - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@5326c89 Signed-off-by: QiuChunshuo <qiuchunshuo@huawei.com>
ZRJ026
pushed a commit
to ZRJ026/vllm-ascend
that referenced
this pull request
Feb 28, 2026
### What this PR does / why we need it? Since the [PR](vllm-project/vllm#28988) for PCP modifications to `GPUModelRunner` has not yet been merged into vLLM, this PR temporarily requires adjustments to certain buffer sizes. These changes can be reverted once the original [PR](vllm-project/vllm#28988) is merged. ### Does this PR introduce _any_ user-facing change? No - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@5326c89 Signed-off-by: QiuChunshuo <qiuchunshuo@huawei.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
maoxx241
pushed a commit
to maoxx241/vllm-ascend
that referenced
this pull request
Mar 2, 2026
### What this PR does / why we need it? Since the [PR](vllm-project/vllm#28988) for PCP modifications to `GPUModelRunner` has not yet been merged into vLLM, this PR temporarily requires adjustments to certain buffer sizes. These changes can be reverted once the original [PR](vllm-project/vllm#28988) is merged. ### Does this PR introduce _any_ user-facing change? No - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@5326c89 Signed-off-by: QiuChunshuo <qiuchunshuo@huawei.com>
ZRJ026
pushed a commit
to ZRJ026/vllm-ascend
that referenced
this pull request
Mar 4, 2026
### What this PR does / why we need it? Since the [PR](vllm-project/vllm#28988) for PCP modifications to `GPUModelRunner` has not yet been merged into vLLM, this PR temporarily requires adjustments to certain buffer sizes. These changes can be reverted once the original [PR](vllm-project/vllm#28988) is merged. ### Does this PR introduce _any_ user-facing change? No - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@5326c89 Signed-off-by: QiuChunshuo <qiuchunshuo@huawei.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
LCAIZJ
pushed a commit
to LCAIZJ/vllm-ascend
that referenced
this pull request
Mar 7, 2026
### What this PR does / why we need it? Since the [PR](vllm-project/vllm#28988) for PCP modifications to `GPUModelRunner` has not yet been merged into vLLM, this PR temporarily requires adjustments to certain buffer sizes. These changes can be reverted once the original [PR](vllm-project/vllm#28988) is merged. ### Does this PR introduce _any_ user-facing change? No - vLLM version: v0.13.0 - vLLM main: vllm-project/vllm@5326c89 Signed-off-by: QiuChunshuo <qiuchunshuo@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Since the PR for PCP modifications to
GPUModelRunnerhas not yet been merged into vLLM, this PR temporarily requires adjustments to certain buffer sizes. These changes can be reverted once the original PR is merged.Does this PR introduce any user-facing change?
No