Skip to content

[Kernel]update csrc cmakelist for open-source cann#5458

Merged
zzzzwwjj merged 1 commit intovllm-project:mainfrom
Fager10086:modify_for_cann
Dec 29, 2025
Merged

[Kernel]update csrc cmakelist for open-source cann#5458
zzzzwwjj merged 1 commit intovllm-project:mainfrom
Fager10086:modify_for_cann

Conversation

@Fager10086
Copy link
Copy Markdown
Contributor

@Fager10086 Fager10086 commented Dec 29, 2025 •
edited by Yikun
Loading

What this PR does / why we need it?

Using open-source CANN, installation errors may occur due to changes in the path of the aclnn directory. So we add the header file.

Using open-source CANN, installation errors may occur due to changes in the path of the base/dlog_pub.h for aclnn.

RFC: #5494

Does this PR introduce any user-facing change?

Does not.

How was this patch tested?

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an installation error with open-source CANN by adding a new include path. While the change correctly identifies the need for an additional path, it hardcodes the aarch64-linux architecture. This will likely break builds on other platforms. My review suggests using the CMAKE_SYSTEM_PROCESSOR variable to make the path architecture-agnostic, which aligns with existing patterns in the file.

Comment thread csrc/CMakeLists.txt Outdated
@Fager10086 Fager10086 force-pushed the modify_for_cann branch 2 times, most recently from 6bbbae9 to c48f50f Compare December 29, 2025 03:21
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 29, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@Fager10086 @zzzzwwjj
update csrc cmakelist for open-source cann
2685fd5 
Signed-off-by: Rifa <865071616@qq.com>
@zzzzwwjj zzzzwwjj merged commit 51da5ea into vllm-project:main Dec 29, 2025
9 of 11 checks passed
@Yikun Yikun mentioned this pull request Dec 30, 2025
Closed
1 task
845473182 pushed a commit to 845473182/vllm-ascend that referenced this pull request Dec 31, 2025
Merge branch 'main' of https://github.com/vllm-project/vllm-ascend in…
048b04f 
…to FIA_rebase

* 'main' of https://github.com/vllm-project/vllm-ascend: (88 commits)
  [1/N] Refactor nightly test structure (vllm-project#5479)
  Docs: Remove deprecated --task parameter for embedding models (vllm-project#5257)
  Revert "moe_gating_top_k" (vllm-project#5512)
  [Doc] Fix issue link for 0.12.0 (vllm-project#5500)
  [CI]update triton ascend version (vllm-project#5392)
  moe_gating_top_k (vllm-project#5271)
  [refactor] refactor model runner capture model (vllm-project#5230)
  Update corresponding vllm commit ID to 12 29 (vllm-project#5475)
  [Kernel]update csrc cmakelist for open-source cann (vllm-project#5458)
  [OP] add custom op aclnnMoeInitRoutingCustom (vllm-project#5251)
  [Refactor][EAGLE] 1/N delete __init__ in mtp_proposer (vllm-project#5176)
  [Refactor][Triton] Move reject sample triton kernels into ops/triton (vllm-project#5324)
  [Feature] support eager mode in model runner v2 (vllm-project#5210)
  [feature] fia support sliding windows (vllm-project#5239)
  Optimize some rejectsampler functions to make npu op launch non-blocking (vllm-project#4587)
  [Feature] Support to use fullgraph with eagle (vllm-project#5118)
  [EPLB][refactor] Modification of the initialization logic for expert_map and log2phy（depend on pr5285） (vllm-project#5311)
  [Refactor]6/N Extract common code of class AscendMLAImpl (vllm-project#5314)
  [Refactor] cache cos/sin in mla & remove parameter model in builder. (vllm-project#5277)
  update vllm pin to 12.27 (vllm-project#5412)
  ...
shenchuxiaofugui pushed a commit to shenchuxiaofugui/vllm-ascend that referenced this pull request Dec 31, 2025
@Fager10086 @shenchuxiaofugui
[Kernel]update csrc cmakelist for open-source cann (vllm-project#5458)
9eeccf3 
### What this PR does / why we need it?

Using open-source CANN, installation errors may occur due to changes in
the path of the aclnn directory. So we add the header file.

- Fixes #
-->
Using open-source CANN, installation errors may occur due to changes in
the path of the base/dlog_pub.h for aclnn.

### Does this PR introduce _any_ user-facing change?
Does not.

### How was this patch tested?


- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@5326c89

Signed-off-by: Rifa <865071616@qq.com>
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Feb 28, 2026
@Fager10086
[Kernel]update csrc cmakelist for open-source cann (vllm-project#5458)
c5eea0e 
### What this PR does / why we need it?

Using open-source CANN, installation errors may occur due to changes in
the path of the aclnn directory. So we add the header file.

- Fixes #
-->
Using open-source CANN, installation errors may occur due to changes in
the path of the base/dlog_pub.h for aclnn.

### Does this PR introduce _any_ user-facing change?
Does not.

### How was this patch tested?

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@5326c89

Signed-off-by: Rifa <865071616@qq.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
maoxx241 pushed a commit to maoxx241/vllm-ascend that referenced this pull request Mar 2, 2026
@Fager10086 @maoxx241
[Kernel]update csrc cmakelist for open-source cann (vllm-project#5458)
f5eecc0 
### What this PR does / why we need it?

Using open-source CANN, installation errors may occur due to changes in
the path of the aclnn directory. So we add the header file.

- Fixes #
-->
Using open-source CANN, installation errors may occur due to changes in
the path of the base/dlog_pub.h for aclnn.

### Does this PR introduce _any_ user-facing change?
Does not.

### How was this patch tested?


- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@5326c89

Signed-off-by: Rifa <865071616@qq.com>
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Mar 4, 2026
@Fager10086
[Kernel]update csrc cmakelist for open-source cann (vllm-project#5458)
b64253b 
### What this PR does / why we need it?

Using open-source CANN, installation errors may occur due to changes in
the path of the aclnn directory. So we add the header file.

- Fixes #
-->
Using open-source CANN, installation errors may occur due to changes in
the path of the base/dlog_pub.h for aclnn.

### Does this PR introduce _any_ user-facing change?
Does not.

### How was this patch tested?

- vLLM version: v0.13.0
- vLLM main:
vllm-project/vllm@5326c89

Signed-off-by: Rifa <865071616@qq.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangxiyuan wangxiyuan wangxiyuan approved these changes

@zzzzwwjj zzzzwwjj zzzzwwjj approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Fager10086 @wangxiyuan @zzzzwwjj