Skip to content

[Bugfix] fix greedy temperature detection #5417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MengqingCao merged 3 commits into from
Dec 27, 2025
Merged

[Bugfix] fix greedy temperature detection #5417

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7080adc
fix greedy temperature detection
realliujiaxu Dec 27, 2025
6ac40c6
import GREEDY_TEMPERATURE from vllm
realliujiaxu Dec 27, 2025
349ffcb
Merge branch 'main' into fix-greedy-temp
MengqingCao Dec 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vllm_ascend/sample/rejection_sampler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
import torch
from vllm.triton_utils import HAS_TRITON, tl, triton
from vllm.v1.sample.metadata import SamplingMetadata
from vllm.v1.sample.rejection_sampler import generate_uniform_probs
from vllm.v1.sample.rejection_sampler import (GREEDY_TEMPERATURE,
generate_uniform_probs)

from vllm_ascend.sample.sampler import apply_top_k_top_p

PLACEHOLDER_TOKEN_ID = -1
Comment thread
realliujiaxu marked this conversation as resolved.
GREEDY_TEMPERATURE = -1
# Maximum number of speculative draft tokens allowed per request in a single
# step. This value is chosen to be large enough to handle typical use cases.
MAX_SPEC_LEN = 32
Expand Down
Loading