-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[Doc] Update DeepSeek V3.1/R1 2P1D doc #5387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data parallelism configuration for the prefill nodes (p0, p1) appears to be incorrect and will likely lead to errors.
Here are the inconsistencies:
dp-sizevs. number of workers:dp-sizeis set to 2, but withdp-size-local=2on two nodes (p0 and p1), you are attempting to launch 4 workers in total. The total number of workers should matchdp-size.dp-rank-startis 0 for both nodes. This will cause data parallel rank conflicts as both nodes will try to launch workers with ranks 0 and 1.dp-addressis different for p0 and p1. For a single data parallel group, all workers should point to the same master address.kv-transfer-configin therun_dp_template.shfor prefill nodes specifies"dp_size": 2, which is inconsistent with launching 4 workers.To fix this for a 2-node, 4-worker prefill setup, you should:
dp-size=4.dp-rank-start=0for p0,dp-rank-start=2for p1).dp-address.dp_sizeto 4 inkv-transfer-configin therun_dp_template.shscripts.I've provided a code suggestion to correct the launch commands, assuming
141.xx.xx.1is the master. You will also need to update thedp_sizeto 4 in theprefillsection ofkv_connector_extra_configwithin therun_dp_template.shscripts for both prefill nodes.