[CI] Add nightly ci test for deepseek v3.1#5386
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds a new nightly CI test for DeepSeek v3.1. My review has identified a few critical issues that will likely cause the test to fail. There are malformed JSON strings in the YAML configuration file for the model, which will lead to argument parsing errors. The run.sh script contains confusing and likely incorrect git commands for checking out dependencies. Additionally, the Kubernetes configuration template includes hardcoded IP addresses, which is a bad practice for maintainability and portability. I have provided suggestions to fix these issues.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
zhangxinyuehfad
force-pushed
the
zxy_dpsk31
branch
from
3ec091f to
90a8011
Compare
zhangxinyuehfad
force-pushed
the
zxy_dpsk31
branch
17 times, most recently
from
b6f5bda to
01d080f
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
zhangxinyuehfad
force-pushed
the
zxy_dpsk31
branch
2 times, most recently
from
262616b to
4778147
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
zhangxinyuehfad
force-pushed
the
zxy_dpsk31
branch
2 times, most recently
from
a0a5047 to
e94a3bb
Compare
zhangxinyuehfad
force-pushed
the
zxy_dpsk31
branch
7 times, most recently
from
e6943d2 to
0d2ef24
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
zhangxinyuehfad
force-pushed
the
zxy_dpsk31
branch
from
0d2ef24 to
e10fdbb
Compare
MengqingCao
left a comment
MengqingCao
left a comment
There was a problem hiding this comment.
LGTM, waiting for an approve from @rjg-lyh
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: hfadzxy <starmoon_zhang@163.com>
zhangxinyuehfad
force-pushed
the
zxy_dpsk31
branch
from
e10fdbb to
c1ac551
Compare
### What this PR does / why we need it? Add nightly ci test for deepseek v3.1 - vLLM version: release/v0.13.0 - vLLM main: vllm-project/vllm@bc0a5a0 Signed-off-by: hfadzxy <starmoon_zhang@163.com>
### What this PR does / why we need it? Add nightly ci test for deepseek v3.1 - vLLM version: release/v0.13.0 - vLLM main: vllm-project/vllm@bc0a5a0 Signed-off-by: hfadzxy <starmoon_zhang@163.com>
### What this PR does / why we need it? Add nightly ci test for deepseek v3.1 - vLLM version: release/v0.13.0 - vLLM main: vllm-project/vllm@bc0a5a0 Signed-off-by: hfadzxy <starmoon_zhang@163.com>
### What this PR does / why we need it? Add nightly ci test for deepseek v3.1 - vLLM version: release/v0.13.0 - vLLM main: vllm-project/vllm@bc0a5a0 Signed-off-by: hfadzxy <starmoon_zhang@163.com>
### What this PR does / why we need it? Add nightly ci test for deepseek v3.1 - vLLM version: release/v0.13.0 - vLLM main: vllm-project/vllm@bc0a5a0 Signed-off-by: hfadzxy <starmoon_zhang@163.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
### What this PR does / why we need it? Add nightly ci test for deepseek v3.1 - vLLM version: release/v0.13.0 - vLLM main: vllm-project/vllm@bc0a5a0 Signed-off-by: hfadzxy <starmoon_zhang@163.com>
3 participants
What this PR does / why we need it?
Add nightly ci test for deepseek v3.1
Does this PR introduce any user-facing change?
How was this patch tested?