Skip to content

Update vllm pin to 12.24#5307

Merged
wangxiyuan merged 2 commits intovllm-project:mainfrom
leo-pony:update_12_24
Dec 24, 2025
Merged

Update vllm pin to 12.24#5307
wangxiyuan merged 2 commits intovllm-project:mainfrom
leo-pony:update_12_24

Conversation

@leo-pony
Copy link
Collaborator

@leo-pony leo-pony commented Dec 24, 2025

What this PR does / why we need it?

Fix vllm break in the pr:

  1. [Add MiMo-V2-Flash support] ([Model] Add MiMo-V2-Flash support vllm#30836)

Does this PR introduce any user-facing change?

How was this patch tested?

Co-authored-by: zxwang 1476209578@qq.com

leo-pony and others added 2 commits December 24, 2025 10:04
Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: zxwang <1476209578@qq.com>
@github-actions
Copy link
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions github-actions bot added documentation Improvements or additions to documentation ci/build module:ops labels Dec 24, 2025
@leo-pony leo-pony marked this pull request as draft December 24, 2025 02:10
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vLLM pin and introduces a v_head_size parameter to AscendQKVParallelLinear. However, the new parameter is not used in the layer's output size calculations, which is a critical bug. I've left a comment with details on how to fix it. The documentation change looks fine.

@leo-pony leo-pony marked this pull request as ready for review December 24, 2025 02:58
@leo-pony leo-pony added ready read for review ready-for-test start test by label for PR labels Dec 24, 2025
@leo-pony
Copy link
Collaborator Author

leo-pony commented Dec 24, 2025

@shenchuxiaofugui Could you help take a look?
failed test case:
tests/e2e/multicard/test_qwen3_moe.py::test_qwen3_moe_w8a8_distributed_tp2_ep_dynamic_eplb FAILED

It's not a function issue. It's my local env issue.

@shenchuxiaofugui
Copy link
Collaborator

export HCCL_BUFFSIZE=1024
export DYNAMIC_EPLB="true"

vllm serve Qwen3-30B-A3B-m4
--served-model-name qwen3
--host 0.0.0.0
--port 20002
--tensor-parallel-size 2
--max_model_len 8192
--enable_expert_parallel
--quantization "ascend"
--enforce_eager
--additional-config '{"dynamic_eplb": true, "num_iterations_eplb_update": 100, "num_wait_worker_iterations": 50}'

@wangxiyuan wangxiyuan merged commit 42c989a into vllm-project:main Dec 24, 2025
54 of 66 checks passed
@leo-pony leo-pony deleted the update_12_24 branch December 30, 2025 06:24
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Feb 28, 2026
### What this PR does / why we need it?
Fix vllm break in the pr:
1. [Add MiMo-V2-Flash support]
(vllm-project/vllm#30836)

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

Co-authored-by: zxwang [1476209578@qq.com](mailto:1476209578@qq.com)

- vLLM version: release/v0.13.0
- vLLM main:
vllm-project/vllm@5fbfa8d

---------

Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: zxwang <1476209578@qq.com>
Co-authored-by: zxwang <1476209578@qq.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Mar 4, 2026
### What this PR does / why we need it?
Fix vllm break in the pr:
1. [Add MiMo-V2-Flash support]
(vllm-project/vllm#30836)

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

Co-authored-by: zxwang [1476209578@qq.com](mailto:1476209578@qq.com)

- vLLM version: release/v0.13.0
- vLLM main:
vllm-project/vllm@5fbfa8d

---------

Signed-off-by: leo-pony <nengjunma@outlook.com>
Signed-off-by: zxwang <1476209578@qq.com>
Co-authored-by: zxwang <1476209578@qq.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build documentation Improvements or additions to documentation module:ops ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants