[Doc] Fix DeepSeek-V3.2 tutorial.#5190
Conversation
Signed-off-by: menogrey <1299267905@qq.com>
There was a problem hiding this comment.
Code Review
This pull request updates the documentation for the DeepSeek-V3.2 tutorial, including model availability, installation instructions, and benchmark commands. The changes largely improve the tutorial's accuracy and clarity. I have one suggestion to make the installation process for Triton Ascend more robust by using pip to handle both download and installation of the wheel file.
| wget https://vllm-ascend.obs.cn-north-4.myhuaweicloud.com/vllm-ascend/triton_ascend-3.2.0.dev2025110717-cp311-cp311-manylinux_2_27_aarch64.whl | ||
| pip install triton_ascend-3.2.0.dev2025110717-cp311-cp311-manylinux_2_27_aarch64.whl |
There was a problem hiding this comment.
Using wget to download the wheel file and then pip install to install it is fragile. If the download is interrupted, the installation will fail with a potentially confusing error. It's more robust and simpler to let pip handle the download and installation in a single step.
| wget https://vllm-ascend.obs.cn-north-4.myhuaweicloud.com/vllm-ascend/triton_ascend-3.2.0.dev2025110717-cp311-cp311-manylinux_2_27_aarch64.whl | |
| pip install triton_ascend-3.2.0.dev2025110717-cp311-cp311-manylinux_2_27_aarch64.whl | |
| pip install https://vllm-ascend.obs.cn-north-4.myhuaweicloud.com/vllm-ascend/triton_ascend-3.2.0.dev2025110717-cp311-cp311-manylinux_2_27_aarch64.whl |
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
### What this PR does / why we need it? Fix DeepSeek-V3.2 tutorial. - vLLM version: v0.12.0 - vLLM main: vllm-project/vllm@ad32e3e Signed-off-by: menogrey <1299267905@qq.com> Signed-off-by: hu-qi <huqi1024@gmail.com>
### What this PR does / why we need it? Fix DeepSeek-V3.2 tutorial. - vLLM version: v0.12.0 - vLLM main: vllm-project/vllm@ad32e3e Signed-off-by: menogrey <1299267905@qq.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
### What this PR does / why we need it? Fix DeepSeek-V3.2 tutorial. - vLLM version: v0.12.0 - vLLM main: vllm-project/vllm@ad32e3e Signed-off-by: menogrey <1299267905@qq.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
What this PR does / why we need it?
Fix DeepSeek-V3.2 tutorial.
Does this PR introduce any user-facing change?
How was this patch tested?