Skip to content

[Doc] Fix DeepSeek-V3.2 tutorial.#5190

Merged
wangxiyuan merged 1 commit intovllm-project:mainfrom
menogrey:fix_doc4
Dec 22, 2025
Merged

[Doc] Fix DeepSeek-V3.2 tutorial.#5190
wangxiyuan merged 1 commit intovllm-project:mainfrom
menogrey:fix_doc4

Conversation

@menogrey
Copy link
Copy Markdown
Collaborator

@menogrey menogrey commented Dec 19, 2025

What this PR does / why we need it?

Fix DeepSeek-V3.2 tutorial.

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: menogrey <1299267905@qq.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for the DeepSeek-V3.2 tutorial, including model availability, installation instructions, and benchmark commands. The changes largely improve the tutorial's accuracy and clarity. I have one suggestion to make the installation process for Triton Ascend more robust by using pip to handle both download and installation of the wheel file.

Comment on lines +48 to +49
wget https://vllm-ascend.obs.cn-north-4.myhuaweicloud.com/vllm-ascend/triton_ascend-3.2.0.dev2025110717-cp311-cp311-manylinux_2_27_aarch64.whl
pip install triton_ascend-3.2.0.dev2025110717-cp311-cp311-manylinux_2_27_aarch64.whl
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Using wget to download the wheel file and then pip install to install it is fragile. If the download is interrupted, the installation will fail with a potentially confusing error. It's more robust and simpler to let pip handle the download and installation in a single step.

Suggested change
wget https://vllm-ascend.obs.cn-north-4.myhuaweicloud.com/vllm-ascend/triton_ascend-3.2.0.dev2025110717-cp311-cp311-manylinux_2_27_aarch64.whl
pip install triton_ascend-3.2.0.dev2025110717-cp311-cp311-manylinux_2_27_aarch64.whl
pip install https://vllm-ascend.obs.cn-north-4.myhuaweicloud.com/vllm-ascend/triton_ascend-3.2.0.dev2025110717-cp311-cp311-manylinux_2_27_aarch64.whl

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 19, 2025
@wangxiyuan wangxiyuan merged commit dc04748 into vllm-project:main Dec 22, 2025
13 checks passed
hu-qi pushed a commit to hu-qi/vllm-ascend that referenced this pull request Dec 22, 2025
### What this PR does / why we need it?
Fix DeepSeek-V3.2 tutorial.

- vLLM version: v0.12.0
- vLLM main:
vllm-project/vllm@ad32e3e

Signed-off-by: menogrey <1299267905@qq.com>
Signed-off-by: hu-qi <huqi1024@gmail.com>
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Feb 28, 2026
### What this PR does / why we need it?
Fix DeepSeek-V3.2 tutorial.

- vLLM version: v0.12.0
- vLLM main:
vllm-project/vllm@ad32e3e

Signed-off-by: menogrey <1299267905@qq.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Mar 4, 2026
### What this PR does / why we need it?
Fix DeepSeek-V3.2 tutorial.

- vLLM version: v0.12.0
- vLLM main:
vllm-project/vllm@ad32e3e

Signed-off-by: menogrey <1299267905@qq.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants