Skip to content

[BugFix] Fix top_p,top_k issue with EAGLE and add top_p,top_k in EAGLE e2e#5131

Merged
wangxiyuan merged 1 commit intovllm-project:mainfrom
zhaomingyu13:main
Dec 18, 2025
Merged

[BugFix] Fix top_p,top_k issue with EAGLE and add top_p,top_k in EAGLE e2e#5131
wangxiyuan merged 1 commit intovllm-project:mainfrom
zhaomingyu13:main

Conversation

@zhaomingyu13
Copy link
Copy Markdown
Contributor

@zhaomingyu13 zhaomingyu13 commented Dec 17, 2025 •
edited by github-actions bot
Loading

What this PR does / why we need it?

Add top_p,top_k in EAGLE e2e

Does this PR introduce any user-facing change?

How was this patch tested?

@zhaomingyu13 zhaomingyu13 changed the title [BugFix] Fix EAGLE issue with top_p,top_k [BugFix] Add top_p,top_k in EAGLE e2e Dec 17, 2025
@vllm-ascend-ci vllm-ascend-ci added ready read for review ready-for-test start test by label for PR labels Dec 17, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 17, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@zhaomingyu13 zhaomingyu13 changed the title [BugFix] Add top_p,top_k in EAGLE e2e [BugFix] Fix top_p,top_k issue with EAGLE and add top_p,top_k in EAGLE e2e Dec 18, 2025
@zhaomingyu13
[BugFix] Add top_p,top_k in EAGLE e2e
7550044 
Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
@wangxiyuan wangxiyuan merged commit 73e4b4f into vllm-project:main Dec 18, 2025
25 checks passed
845473182 pushed a commit to 845473182/vllm-ascend that referenced this pull request Dec 19, 2025
Merge branch 'main' of https://github.com/vllm-project/vllm-ascend in…
7acc6cc 
…to eplb_refactor

* 'main' of https://github.com/vllm-project/vllm-ascend: (52 commits)
  [Doc]Add the user_guide doc file regarding fine-grained TP. (vllm-project#5084)
  [pref] qwen3_next add triton ops : fused_sigmoid_gating_delta_rule_update (vllm-project#4818)
  [Feature] Add token mask for DispatchGmmCombineDecode operator (vllm-project#5171)
  [CI] Improve CI (vllm-project#5078)
  [Refactor] remove some metadata variables in attention_v1. (vllm-project#5160)
  Add Qwen3-VL-235B-A22B-Instruct tutorials (vllm-project#5167)
  [Doc] Add a perf tune section (vllm-project#5127)
  [Image] Refactor image build (vllm-project#5175)
  [refactor] refactor weight trans nz and transpose (vllm-project#4878)
  [BugFix]Fix precision issue for LoRA feature (vllm-project#4141)
  【Doc】Deepseekv3.1/R1 doc enhancement (vllm-project#4827)
  support basic long_seq feature st (vllm-project#5140)
  [Bugfix] install trition for test_custom_op (vllm-project#5112)
  [2/N][Pangu][MoE] Remove Pangu Related Code (vllm-project#5130)
  [bugfix] Use FUSED_MC2 MoE comm path for the op `dispatch_ffn_combine` (vllm-project#5156)
  [BugFix] Fix top_p,top_k issue with EAGLE and add top_p,top_k in EAGLE e2e (vllm-project#5131)
  [Doc][P/D] Fix MooncakeConnector's name (vllm-project#5172)
  [Bugfix] Fix in_profile_run in mtp_proposer dummy_run (vllm-project#5165)
  [Doc] Refact benchmark doc (vllm-project#5173)
  [Nightly]  Avoid max_model_len being smaller than the decoder prompt to prevent single-node-accuray-tests from failing (vllm-project#5174)
  ...

Signed-off-by: 白永斌 <baiyongbin3@h-partners.com>
chenaoxuan pushed a commit to chenaoxuan/vllm-ascend that referenced this pull request Dec 20, 2025
@zhaomingyu13 @chenaoxuan
[BugFix] Fix top_p,top_k issue with EAGLE and add top_p,top_k in EAGL…
f39b5c0 
…E e2e (vllm-project#5131)

### What this PR does / why we need it?
Add top_p,top_k in EAGLE e2e

- vLLM version: v0.12.0
- vLLM main:
vllm-project/vllm@ad32e3e

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Feb 28, 2026
@zhaomingyu13
[BugFix] Fix top_p,top_k issue with EAGLE and add top_p,top_k in EAGL…
4e3e626 
…E e2e (vllm-project#5131)

### What this PR does / why we need it?
Add top_p,top_k in EAGLE e2e

- vLLM version: v0.12.0
- vLLM main:
vllm-project/vllm@ad32e3e

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
ZRJ026 pushed a commit to ZRJ026/vllm-ascend that referenced this pull request Mar 4, 2026
@zhaomingyu13
[BugFix] Fix top_p,top_k issue with EAGLE and add top_p,top_k in EAGL…
1a0b07a 
…E e2e (vllm-project#5131)

### What this PR does / why we need it?
Add top_p,top_k in EAGLE e2e

- vLLM version: v0.12.0
- vLLM main:
vllm-project/vllm@ad32e3e

Signed-off-by: zhaomingyu <zhaomingyu13@h-partners.com>
Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wangxiyuan wangxiyuan wangxiyuan approved these changes

@realliujiaxu realliujiaxu realliujiaxu approved these changes

Assignees

No one assigned

Labels

module:tests ready read for review ready-for-test start test by label for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhaomingyu13 @wangxiyuan @realliujiaxu @vllm-ascend-ci