Skip to content

[Bugfix] add in_graph_capturing comment#5072

Closed
dragondream-chen wants to merge 0 commit intovllm-project:mainfrom
dragondream-chen:main
Closed

[Bugfix] add in_graph_capturing comment#5072
dragondream-chen wants to merge 0 commit intovllm-project:mainfrom
dragondream-chen:main

Conversation

@dragondream-chen
Copy link
Copy Markdown
Collaborator

@dragondream-chen dragondream-chen commented Dec 16, 2025

What this PR does / why we need it?

Add the value "in_graph_capturing " comment

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a bugfix for speculative decoding with graph capture. The changes correctly propagate the graph capture status to the MTP proposer and adjust the logic within the proposer to only capture the first speculative token generation, which is the intended behavior. A helpful comment has also been added to clarify the purpose of the force_attention flag. The fix appears correct and addresses the issue effectively.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@dragondream-chen dragondream-chen changed the title [Bugfix] add force_attention comment [Bugfix] add in_graph_capturing comment Dec 18, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-conflicts ready read for review ready-for-test start test by label for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants