[Bugfix] Fix the bug in initializing the shared_weight communication domain in sfa-cp, and fix the mtp weight load in pp>1 situation#4913
Merged
jianzs merged 3 commits intovllm-project:mainfrom Dec 15, 2025
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug where initializing the shared_weight communication domain would fail due to undefined variables. The change moves the variable definitions to a higher scope, ensuring they are always available when needed. While this fixes the immediate bug, I've identified a potential resource leak related to the _SHARED_WEIGHT group initialization that this change makes more likely to occur. Please see my detailed comment.
Contributor
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
zzhx1
force-pushed
the
flashcomm_oshared
branch
from
efcb21d to
5cc0f2c
Compare
zzhx1
force-pushed
the
flashcomm_oshared
branch
from
57a9d61 to
9ecd1ee
Compare
zzhx1
changed the title
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
zzhx1
force-pushed
the
flashcomm_oshared
branch
from
9ecd1ee to
c7065c5
Compare
zzhx1
force-pushed
the
flashcomm_oshared
branch
from
f9f36c4 to
dbff1a6
Compare
Signed-off-by: zzhx1 <zzh_201018@outlook.com>
zzhx1
force-pushed
the
flashcomm_oshared
branch
from
4ab52cc to
fffe348
Compare
jianzs
approved these changes
Dec 15, 2025
chenaoxuan
pushed a commit
to chenaoxuan/vllm-ascend
that referenced
this pull request
Dec 20, 2025
…domain in sfa-cp, and fix the mtp weight load in pp>1 situation (vllm-project#4913) ### What this PR does / why we need it? In PR vllm-project#4188, a small bug was introduced that caused sfa-cp to be unable to find the global_pp_size parameter during initialization, and this PR fixed the issue. - vLLM version: v0.12.0 - vLLM main: vllm-project/vllm@ad32e3e Signed-off-by: zzhx1 <zzh_201018@outlook.com> Co-authored-by: Jade Zheng <zheng.shoujian@outlook.com>
ZRJ026
pushed a commit
to ZRJ026/vllm-ascend
that referenced
this pull request
Feb 28, 2026
…domain in sfa-cp, and fix the mtp weight load in pp>1 situation (vllm-project#4913) ### What this PR does / why we need it? In PR vllm-project#4188, a small bug was introduced that caused sfa-cp to be unable to find the global_pp_size parameter during initialization, and this PR fixed the issue. - vLLM version: v0.12.0 - vLLM main: vllm-project/vllm@ad32e3e Signed-off-by: zzhx1 <zzh_201018@outlook.com> Co-authored-by: Jade Zheng <zheng.shoujian@outlook.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
ZRJ026
pushed a commit
to ZRJ026/vllm-ascend
that referenced
this pull request
Mar 4, 2026
…domain in sfa-cp, and fix the mtp weight load in pp>1 situation (vllm-project#4913) ### What this PR does / why we need it? In PR vllm-project#4188, a small bug was introduced that caused sfa-cp to be unable to find the global_pp_size parameter during initialization, and this PR fixed the issue. - vLLM version: v0.12.0 - vLLM main: vllm-project/vllm@ad32e3e Signed-off-by: zzhx1 <zzh_201018@outlook.com> Co-authored-by: Jade Zheng <zheng.shoujian@outlook.com> Signed-off-by: zrj026 <zhangrunjiang026@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
In PR #4188, a small bug was introduced that caused sfa-cp to be unable to find the global_pp_size parameter during initialization, and this PR fixed the issue.
Does this PR introduce any user-facing change?
How was this patch tested?