Revert "[Kernel] add custom moe ops for prefill"#4806
Conversation
This reverts commit 0617d7d.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts the addition of custom MoE ops for prefill, which reportedly broke the CI. The changes primarily consist of deleting the newly added files and removing the corresponding code from existing files. The revert appears to be correct and complete. I have one suggestion regarding shell script best practices in csrc/build_aclnn.sh to improve future maintainability and prevent potential bugs.
| rm -rf build output | ||
| echo "building custom ops $CUSTOM_OPS for $SOC_VERSION" | ||
| bash build.sh -n "$CUSTOM_OPS" -c "$SOC_ARG" | ||
| bash build.sh -n $CUSTOM_OPS -c $SOC_ARG |
There was a problem hiding this comment.
While this change is part of a revert to fix a CI failure, removing the quotes around $CUSTOM_OPS and $SOC_ARG is generally unsafe in shell scripting as it can lead to unexpected word splitting and globbing if the variables were to contain spaces or special characters. If these variables must be unquoted for the build.sh script to work correctly, it would be beneficial to add a comment explaining why. This would prevent future contributors from re-introducing quotes and breaking the build again. An even better long-term solution would be to make build.sh robust enough to handle quoted arguments correctly.
|
Thanks |
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Reverts vllm-project#4194 as it broke CI in https://github.com/vllm-project/vllm-ascend/actions/runs/20030369087/job/57437687382?pr=4791 Co-authored-by: wangxiyuan <wangxiyuan1007@gmail.com> Signed-off-by: weijinqian_v1 <weijinqian@huawei.com>
Reverts vllm-project#4194 as it broke CI in https://github.com/vllm-project/vllm-ascend/actions/runs/20030369087/job/57437687382?pr=4791 Co-authored-by: wangxiyuan <wangxiyuan1007@gmail.com>
Reverts vllm-project#4194 as it broke CI in https://github.com/vllm-project/vllm-ascend/actions/runs/20030369087/job/57437687382?pr=4791 Co-authored-by: wangxiyuan <wangxiyuan1007@gmail.com>
2 participants
Reverts #4194 as it broke CI in https://github.com/vllm-project/vllm-ascend/actions/runs/20030369087/job/57437687382?pr=4791