Skip to content

[Fix] skip xlite e2e test #4786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wangxiyuan merged 2 commits into from
Dec 8, 2025
Merged

[Fix] skip xlite e2e test #4786

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d140db9
[BugFix] skip xlite e2e test
lulina Dec 8, 2025
078442d
Merge branch 'main' into vllm_ascend_xlite
wangxiyuan Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/e2e/singlecard/test_xlite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
]


@pytest.mark.skip
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Instead of unconditionally skipping this test with @pytest.mark.skip, it is better practice to mark it as an expected failure using @pytest.mark.xfail. This will still prevent the test from failing the CI, but it keeps the test active in the test suite. If the underlying precision issue is ever resolved and the test starts passing, xfail will flag it as an unexpected pass, providing visibility that the issue may be fixed.

Suggested change
@pytest.mark.skip
@pytest.mark.xfail(reason="Known precision discrepancies between xlite and eager modes")

@pytest.mark.parametrize("model", MODELS)
@pytest.mark.parametrize("max_tokens", [32])
def test_models_with_xlite_decode_only(
Expand Down Expand Up @@ -79,6 +80,7 @@ def test_models_with_xlite_decode_only(
)


@pytest.mark.skip
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Similar to the other test, please use @pytest.mark.xfail instead of @pytest.mark.skip. This clearly documents that there is a known failure and ensures the test is still executed. It improves tracking of the issue and will notify you if the test's behavior changes from failing to passing in the future.

Suggested change
@pytest.mark.skip
@pytest.mark.xfail(reason="Known precision discrepancies between xlite and eager modes")

@pytest.mark.parametrize("model", MODELS)
@pytest.mark.parametrize("max_tokens", [32])
def test_models_with_xlite_full_mode(
Expand Down
Loading