[MM][Perf] Replace VisionPatchEmbed with that in vllm for better performance#4198
[MM][Perf] Replace VisionPatchEmbed with that in vllm for better performance#4198shen-shanshan wants to merge 3 commits intovllm-project:mainfrom
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Code Review
This pull request improves performance by replacing the custom AscendQwen2_5_VisionPatchEmbed with the standard vLLM implementation. The changes, including the removal of the custom class and related weight conversion logic, are consistent and well-justified by the significant performance gains shown in the benchmarks.
However, there is a critical issue: the unit tests for the removed AscendQwen2_5_VisionPatchEmbed in tests/ut/models/test_qwen2_5_vl.py have not been deleted. This will cause an ImportError and break the build. Please remove the obsolete TestAscendQwen2_5_VisionPatchEmbed class and its import from the test file.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
These changes have been merge into #4349. |
What this PR does / why we need it?
Replace
VisionPatchEmbedwith that in vllm for better performance.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Run:
cd /workspace/vllm-ascend bash benchmarks/scripts/run-performance-benchmarks.shBefore this PR:
After this PR: