Revert "[Feat] Shared expert dp for deepseek and deepseek_mtp (#3495)"#3586
Merged
wangxiyuan merged 1 commit intovllm-project:mainfrom Oct 21, 2025
Merged
Revert "[Feat] Shared expert dp for deepseek and deepseek_mtp (#3495)"#3586wangxiyuan merged 1 commit intovllm-project:mainfrom
wangxiyuan merged 1 commit intovllm-project:mainfrom
Conversation
Contributor
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
linfeng-yuan
force-pushed
the
revert_pr_3495
branch
from
463a42a to
d27f82a
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is intended to revert the 'Shared expert dp for deepseek and deepseek_mtp' feature. While most of the changes correctly revert the feature, I've found that some files are incorrectly adding parts of the feature back in. Specifically, vllm_ascend/platform.py and vllm_ascend/spec_decode/mtp_proposer.py contain additions related to enable_shared_expert_dp which contradict the goal of this revert. These changes need to be corrected to complete the revert properly. Please see my detailed comments.
linfeng-yuan
added
ready
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…roject#3495)" This reverts commit bf87606. Signed-off-by: linfeng-yuan <1102311262@qq.com>
linfeng-yuan
force-pushed
the
revert_pr_3495
branch
from
d27f82a to
45a67fe
Compare
wangxiyuan
approved these changes
Oct 21, 2025
ZYang6263
pushed a commit
to rjg-lyh/vllm-ascend
that referenced
this pull request
Oct 23, 2025
…roject#3495)" (vllm-project#3586) This reverts commit vllm-project@bf87606. No. E2E vllm serving with `enable_shared_expert_dp: true` in eager mode as before. - vLLM version: v0.11.0rc3 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0 Signed-off-by: linfeng-yuan <1102311262@qq.com>
luolun
pushed a commit
to luolun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
…roject#3495)" (vllm-project#3586) ### What this PR does / why we need it? This reverts commit vllm-project@bf87606. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? E2E vllm serving with `enable_shared_expert_dp: true` in eager mode as before. - vLLM version: v0.11.0rc3 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0 Signed-off-by: linfeng-yuan <1102311262@qq.com> Signed-off-by: luolun <luolun1995@cmbchina.com>
hwhaokun
pushed a commit
to hwhaokun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
…roject#3495)" (vllm-project#3586) ### What this PR does / why we need it? This reverts commit vllm-project@bf87606. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? E2E vllm serving with `enable_shared_expert_dp: true` in eager mode as before. - vLLM version: v0.11.0rc3 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0 Signed-off-by: linfeng-yuan <1102311262@qq.com> Signed-off-by: hwhaokun <haokun0405@163.com>
NSDie
pushed a commit
to NSDie/vllm-ascend
that referenced
this pull request
Nov 24, 2025
…roject#3495)" (vllm-project#3586) ### What this PR does / why we need it? This reverts commit vllm-project@bf87606. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? E2E vllm serving with `enable_shared_expert_dp: true` in eager mode as before. - vLLM version: v0.11.0rc3 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0 Signed-off-by: linfeng-yuan <1102311262@qq.com> Signed-off-by: nsdie <yeyifan@huawei.com>
Clorist33
pushed a commit
to Clorist33/vllm-ascend
that referenced
this pull request
Dec 9, 2025
…roject#3495)" (vllm-project#3586) ### What this PR does / why we need it? This reverts commit vllm-project@bf87606. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? E2E vllm serving with `enable_shared_expert_dp: true` in eager mode as before. - vLLM version: v0.11.0rc3 - vLLM main: https://github.com/vllm-project/vllm/commit/v0.11.0 Signed-off-by: linfeng-yuan <1102311262@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This reverts commit bf87606.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
E2E vllm serving with
enable_shared_expert_dp: truein eager mode as before.