Skip to content

use torchvision to read video instead of decord - #341

Closed
zouyida2002 wants to merge 5 commits into
vllm-project:mainfrom
zouyida2002:main
Closed

zouyida2002 wants to merge 5 commits into
vllm-project:mainfrom
zouyida2002:main

Conversation

@zouyida2002

Copy link
Copy Markdown
Contributor

What this PR does / why we need it?

use torchvision to read video instead of decord which is not friendly to NPU.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

I've test it on benchmark and it is equal to GPU.

Signed-off-by: zouyida <zouyida@huawei.com>
Signed-off-by: zouyida <zouyida@huawei.com>
Signed-off-by: zouyida <zouyida@huawei.com>
Signed-off-by: zouyida <zouyida@huawei.com>
Signed-off-by: zouyida <zouyida@huawei.com>
@wangxiyuan

wangxiyuan commented Mar 20, 2025 •

Copy link
Copy Markdown
Collaborator

Talked offline, this is not needed currenlty. Users can build decord from source on aarch64. And vllm will update to use torchcodec instead. This PR is no need. vllm-project/vllm#15022

@wangxiyuan wangxiyuan closed this Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants