[P/D] [Misc] Remove useless PD check in deepseek#2739
Merged
wangxiyuan merged 2 commits intovllm-project:mainfrom Sep 4, 2025
Merged
[P/D] [Misc] Remove useless PD check in deepseek#2739wangxiyuan merged 2 commits intovllm-project:mainfrom
wangxiyuan merged 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: liziyu <liziyu16@huawei.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes hardcoded logic related to prefill/decode disaggregation, where the with_prefill flag was forced to specific values based on whether a node was a kv_producer or kv_consumer. While this simplifies the code by relying on the caller-provided context, it may introduce issues. Specifically, the changes could lead to incorrect behavior during profiling and graph capture for producer and consumer nodes in a disaggregated setup, as the assumptions about their roles during dummy runs seem to be violated. I've added two comments highlighting these potential issues.
Contributor
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2739 +/- ##
==========================================
+ Coverage 72.57% 72.99% +0.42%
==========================================
Files 150 153 +3
Lines 21372 21331 -41
==========================================
+ Hits 15511 15571 +60
+ Misses 5861 5760 -101
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: liziyu <liziyu16@huawei.com>
wangxiyuan
changed the title
wangxiyuan
approved these changes
Sep 4, 2025
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Sep 10, 2025
### What this PR does / why we need it? Remove useless PD check in deepseek - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@6c7af81 --------- Signed-off-by: liziyu <liziyu16@huawei.com>
offline893
pushed a commit
to offline893/vllm-ascend
that referenced
this pull request
Sep 16, 2025
### What this PR does / why we need it? Remove useless PD check in deepseek - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@6c7af81 --------- Signed-off-by: liziyu <liziyu16@huawei.com> Signed-off-by: offline0806 <z00858301@china.huawei.com>
wangxiaoteng888
pushed a commit
to LCAIZJ/vllm-ascend
that referenced
this pull request
Sep 25, 2025
### What this PR does / why we need it? Remove useless PD check in deepseek - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@6c7af81 --------- Signed-off-by: liziyu <liziyu16@huawei.com>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Sep 26, 2025
Remove useless PD check in deepseek - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@6c7af81 --------- Signed-off-by: liziyu <liziyu16@huawei.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
### What this PR does / why we need it? Remove useless PD check in deepseek - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@6c7af81 --------- Signed-off-by: liziyu <liziyu16@huawei.com>
liziyu179
changed the title
NSDie
pushed a commit
to NSDie/vllm-ascend
that referenced
this pull request
Nov 24, 2025
### What this PR does / why we need it? Remove useless PD check in deepseek - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@6c7af81 --------- Signed-off-by: liziyu <liziyu16@huawei.com> Signed-off-by: nsdie <yeyifan@huawei.com>
Clorist33
pushed a commit
to Clorist33/vllm-ascend
that referenced
this pull request
Dec 9, 2025
### What this PR does / why we need it? Remove useless PD check in deepseek - vLLM version: v0.10.1.1 - vLLM main: vllm-project/vllm@6c7af81 --------- Signed-off-by: liziyu <liziyu16@huawei.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Remove useless PD check in deepseek