Fix lint for lora (#2325)#2439
Conversation
Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
|
Curious why #2325 didn't trigger this? |
There was a problem hiding this comment.
Code Review
This pull request aims to fix linting issues. However, the formatting changes applied across the files have resulted in code that is less readable and does not conform to standard Python style guides like PEP 8. The new formatting for function calls and signatures uses unconventional indentation, making the code harder to maintain. My review includes suggestions to reformat the code using a more standard and readable style, such as the one enforced by the black formatter.
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
|
Replaced by #2430 |
What this PR does / why we need it?
Fix lint for lora
Does this PR introduce any user-facing change?
No
How was this patch tested?
bash format.sh