Skip to content

Fix lint for lora (#2325)#2439

Closed
Yikun wants to merge 1 commit intovllm-project:mainfrom
Yikun:fix-lint
Closed

Fix lint for lora (#2325)#2439
Yikun wants to merge 1 commit intovllm-project:mainfrom
Yikun:fix-lint

Conversation

@Yikun
Copy link
Copy Markdown
Member

@Yikun Yikun commented Aug 19, 2025

What this PR does / why we need it?

Fix lint for lora

Does this PR introduce any user-facing change?

No

How was this patch tested?

bash format.sh

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun
Copy link
Copy Markdown
Member Author

Yikun commented Aug 19, 2025

Curious why #2325 didn't trigger this?

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix linting issues. However, the formatting changes applied across the files have resulted in code that is less readable and does not conform to standard Python style guides like PEP 8. The new formatting for function calls and signatures uses unconventional indentation, making the code harder to maintain. My review includes suggestions to reformat the code using a more standard and readable style, such as the one enforced by the black formatter.

Comment thread vllm_ascend/lora/punica_wrapper/lora_ops.py
Comment thread vllm_ascend/lora/punica_wrapper/lora_ops.py
Comment thread vllm_ascend/lora/punica_wrapper/lora_ops.py
Comment thread vllm_ascend/meta_registration.py
Comment thread vllm_ascend/meta_registration.py
@github-actions
Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@Yikun
Copy link
Copy Markdown
Member Author

Yikun commented Aug 19, 2025

Replaced by #2430

@Yikun Yikun closed this Aug 19, 2025
@Yikun Yikun reopened this Aug 19, 2025
@Yikun Yikun closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant