Skip to content

ut: add ci guard for ut coverage #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yikun merged 3 commits into from
Aug 12, 2025
Merged

ut: add ci guard for ut coverage #2317

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9fbf3d
ut: add ci guard for ut coverage
Ronald1995 Aug 11, 2025
4eab36f
Update codecov.yml
Yikun Aug 11, 2025
7bd89ff
Update codecov.yml
Yikun Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,10 @@

coverage:
status:
# non-voting, new code must be fully tested
# Patch coverage is mandatory and must be >= 80%
patch:
default:
target: 100%
# non-voting
informational: true
target: 80%
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Setting the target to 80% and removing informational: true makes the patch coverage check mandatory, which is a great improvement for ensuring code quality. However, this change makes the comment on line 20 (# non-voting, new code must be fully tested) inaccurate. To avoid confusion for future contributors, please consider updating it. For example, you could change it to # Patch coverage is mandatory and must be >= 80% or simply remove the 'non-voting' part.

# non-voting
project:
default:
Expand Down
Loading