bump default python version to 3.11 #2072
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yikun
reviewed
Jul 28, 2025
.pre-commit-config.yaml
Outdated
| - id: mypy-3.10 # TODO: Use https://github.com/pre-commit/mirrors-mypy when mypy setup is less awkward | ||
| name: Run mypy for Python 3.10 | ||
| entry: tools/mypy.sh 1 "3.10" | ||
| - id: mypy-3.11 # TODO: Use https://github.com/pre-commit/mirrors-mypy when mypy setup is less awkward |
Collaborator
There was a problem hiding this comment.
This shouldn't be changed
Collaborator
Author
There was a problem hiding this comment.
Should I keep the original code like this:
- id: mypy-3.10 # TODO: Use https://github.com/pre-commit/mirrors-mypy when mypy setup is less awkward
name: Run mypy for Python 3.10
entry: tools/mypy.sh 1 "3.10"
Or just remove the # TODO comment and just keep:
- id: mypy-3.11
name: Run mypy for Python 3.11
entry: tools/mypy.sh 1 "3.11"
Collaborator
There was a problem hiding this comment.
keep the original code, this PR only make 3.11 as default, but not drop 3.10 support
Signed-off-by: ChenTaoyu-SJTU <[email protected]>
ChenTaoyu-SJTU
force-pushed
the
Bump_default_python_version_to_3_11
branch
from
b169533 to
6329192
Compare
wangxiyuan
approved these changes
Jul 29, 2025
weijinqian0
pushed a commit
to weijinqian0/vllm-ascend
that referenced
this pull request
Jul 30, 2025
### What this PR does / why we need it? Bump default python version to 3.11, see vllm-project#1980 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? pass CI - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@12a223e Signed-off-by: ChenTaoyu-SJTU <[email protected]>
weijinqian0
pushed a commit
to weijinqian0/vllm-ascend
that referenced
this pull request
Jul 30, 2025
### What this PR does / why we need it? Bump default python version to 3.11, see vllm-project#1980 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? pass CI - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@12a223e Signed-off-by: ChenTaoyu-SJTU <[email protected]> Signed-off-by: weijinqian_v1 <[email protected]>
This was referenced Jul 31, 2025
ganyi1996ppo
pushed a commit
that referenced
this pull request
Aug 1, 2025
### What this PR does / why we need it? Upgrade python to 3.11 Soft backport: #2072 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed Signed-off-by: Yikun Jiang <[email protected]>
4 tasks
wangxiyuan
pushed a commit
that referenced
this pull request
Sep 8, 2025
### What this PR does / why we need it? Switch Infra to linux-aarch64-a2 and python to 3.11 Soft backport: #2065 Soft backport: #2072 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI passed search all: `linux-arm64-npu` and `3.10` --------- Signed-off-by: Yikun Jiang <[email protected]>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Sep 26, 2025
### What this PR does / why we need it? Bump default python version to 3.11, see vllm-project#1980 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? pass CI - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@12a223e Signed-off-by: ChenTaoyu-SJTU <[email protected]>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
### What this PR does / why we need it? Bump default python version to 3.11, see vllm-project#1980 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? pass CI - vLLM version: v0.10.0 - vLLM main: vllm-project/vllm@12a223e Signed-off-by: ChenTaoyu-SJTU <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Bump default python version to 3.11, see #1980
Does this PR introduce any user-facing change?
no
How was this patch tested?
pass CI