[1/4][Refactor] Refactor torchair worker#1885
Merged
wangxiyuan merged 1 commit intovllm-project:mainfrom Jul 21, 2025
Merged
Conversation
wangxiyuan
force-pushed
the
refactor_torchair_1
branch
2 times, most recently
from
27ffe8e to
bd7d84c
Compare
wangxiyuan
force-pushed
the
refactor_torchair_1
branch
from
bd7d84c to
6156470
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1885 +/- ##
==========================================
+ Coverage 60.17% 60.21% +0.03%
==========================================
Files 71 71
Lines 7989 7997 +8
==========================================
+ Hits 4807 4815 +8
Misses 3182 3182
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wangxiyuan
force-pushed
the
refactor_torchair_1
branch
2 times, most recently
from
54956b1 to
e1cdc08
Compare
Collaborator
Author
|
I just update docstring and ut in new commit. The CI passed here: https://github.com/vllm-project/vllm-ascend/actions/runs/16405875733?pr=1885 No need to run the e2e again. |
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
wangxiyuan
force-pushed
the
refactor_torchair_1
branch
from
e1cdc08 to
cff3d59
Compare
Yikun
approved these changes
Jul 21, 2025
Collaborator
Author
|
UT passed. Let's merge this in quick |
6 tasks
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Sep 26, 2025
There is a lot torchair specified logic in common code. It results hard code maintenance. We will create a new torchair module to launch torchair related logic there. I plan to add 4 PR. 1. Refactor worker (this PR) - create torchair module and move torchair related code in worker to the new module 3. Refactor utils 4. Refactor model_runner 5. Refactor attention - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@8188196 Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
There is a lot torchair specified logic in common code. It results hard code maintenance. We will create a new torchair module to launch torchair related logic there. I plan to add 4 PR. 1. Refactor worker (this PR) - create torchair module and move torchair related code in worker to the new module 3. Refactor utils 4. Refactor model_runner 5. Refactor attention - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@8188196 Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Clorist33
pushed a commit
to Clorist33/vllm-ascend
that referenced
this pull request
Dec 9, 2025
There is a lot torchair specified logic in common code. It results hard code maintenance. We will create a new torchair module to launch torchair related logic there. I plan to add 4 PR. 1. Refactor worker (this PR) - create torchair module and move torchair related code in worker to the new module 3. Refactor utils 4. Refactor model_runner 5. Refactor attention - vLLM version: v0.9.2 - vLLM main: vllm-project/vllm@8188196 Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a lot torchair specified logic in common code. It results hard code maintenance. We will create a new torchair module to launch torchair related logic there. I plan to add 4 PR.