[0.9.1][Perf]Remove NZ of kv_b_proj in Deepseek MLA.#1872
Merged
ganyi1996ppo merged 1 commit intovllm-project:v0.9.1-devfrom Jul 19, 2025
Merged
[0.9.1][Perf]Remove NZ of kv_b_proj in Deepseek MLA.#1872ganyi1996ppo merged 1 commit intovllm-project:v0.9.1-devfrom
ganyi1996ppo merged 1 commit intovllm-project:v0.9.1-devfrom
Conversation
Signed-off-by: whx-sjtu <2952154980@qq.com>
Contributor
|
#1131 This PR does this |
NNUCJ
pushed a commit
to NNUCJ/vllm-ascend
that referenced
this pull request
Jul 21, 2025
This PR removes NZ transformation of weights of kv_b_proj. This is because we find that this matmul weight is not quantized and will fall back to ND calculation in runtime (because currently float bmm nz is not supported in torchair graph), which causes two redundant transData operations (trans weight from NZ back to ND). Removing these two operations will provide an optimization of about 40us per layer. Signed-off-by: whx-sjtu <2952154980@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes NZ transformation of weights of kv_b_proj. This is because we find that this matmul weight is not quantized and will fall back to ND calculation in runtime (because currently float bmm nz is not supported in torchair graph), which causes two redundant transData operations (trans weight from NZ back to ND). Removing these two operations will provide an optimization of about 40us per layer.