Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. Tip 💡 Consider Linking a Related Issue or RFCYour PR title contains the [BugFix] tag, indicating a bug fix or new feature. Linking a related issue or RFC in the PR description is strongly encouraged — it gives reviewers helpful context and speeds up the review. You can use any of these keywords:
🙏 Thanks for helping us keep the project well-organized! |
|
/nightly qwen3-30b-a3b-w8a8-a2-performance
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts the UpdatableGraph implementation, returning the system to the previous, more stable path for FIA and speculative-decoding graph replay. It maintains subsequent unrelated improvements while cleaning up the codebase by removing the deprecated UpdatableGraph class and its dependencies. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
/nightly Qwen3-235B-disagg-pd |
There was a problem hiding this comment.
Code Review
Suggested PR Title:
[Attention][Misc] Refactor attention graph replay to remove UpdatableGraph and use standard NPUGraphSuggested PR Summary:
### What this PR does / why we need it?
This PR refactors the attention graph replay mechanism by completely removing the custom `UpdatableGraph` implementation and replacing it with PyTorch's standard `torch.npu.NPUGraph`. The graph parameter update logic for both Paged Attention and Fused Infer Attention (FIA) has been consolidated directly into `AscendAttentionBackendImpl.update_graph_params`. This simplifies the codebase, removes redundant metadata update paths in speculative decoding proposers, and cleans up the `weak_ref_tensors` utility.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Tested with existing and updated unit tests in `tests/ut/attention/test_attention_v1.py` and `tests/ut/compilation/test_acl_graph.py`.I have no further feedback to provide as there are no review comments.
|
/nightly Qwen3-235B-disagg-pd |
1 similar comment
|
/nightly Qwen3-235B-disagg-pd |
|
/nightly multi-node-qwen-disagg-pd
|
fb502f1 to
c173a64
Compare
…6798
This reverts commit 34bb51f.
Restore FIA and speculative-decoding graph replay to the pre-UpdatableGraph path. Keep later unrelated changes already present on the branch, including attention_transfer_window from #16747 and the vLLM 0.29.0 PCP import from #17004.
What this PR does / why we need it?
Does this PR introduce any user-facing change?
How was this patch tested?