Skip to content

[Bugfix] Revert host-side ACL graph parameter updates from #1… - #17087

Closed
shiqiangA wants to merge 0 commit into
vllm-project:mainfrom
shiqiangA:test_nightly2
Closed

shiqiangA wants to merge 0 commit into
vllm-project:mainfrom
shiqiangA:test_nightly2

Conversation

@shiqiangA

@shiqiangA shiqiangA commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

…6798

This reverts commit 34bb51f.

Restore FIA and speculative-decoding graph replay to the pre-UpdatableGraph path. Keep later unrelated changes already present on the branch, including attention_transfer_window from #16747 and the vLLM 0.29.0 PCP import from #17004.

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.


Tip

💡 Consider Linking a Related Issue or RFC

Your PR title contains the [BugFix] tag, indicating a bug fix or new feature.

Linking a related issue or RFC in the PR description is strongly encouraged — it gives reviewers helpful context and speeds up the review. You can use any of these keywords:

  • Fixes #<issue_number>
  • Closes #<issue_number>
  • Resolves #<issue_number>
  • Refs #<rfc_or_issue_number> (for RFCs)

🙏 Thanks for helping us keep the project well-organized!

@shiqiangA

shiqiangA commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator Author

/nightly qwen3-30b-a3b-w8a8-a2-performance
nightly command triggered.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts the UpdatableGraph implementation, returning the system to the previous, more stable path for FIA and speculative-decoding graph replay. It maintains subsequent unrelated improvements while cleaning up the codebase by removing the deprecated UpdatableGraph class and its dependencies.

Highlights

  • Revert UpdatableGraph: Reverted the host-side ACL graph parameter updates introduced in [Feature][MRV1][MRV2] Refactor Host-Side Parameter Updates for ACL Graph Replay. #16798, effectively removing the UpdatableGraph implementation.
  • Restore Graph Replay Path: Restored FIA and speculative-decoding graph replay to the pre-UpdatableGraph path to ensure stability.
  • Codebase Cleanup: Removed the UpdatableGraph class and all associated dependencies, helper methods, and test mocks across the repository.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@shiqiangA

shiqiangA commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator Author

/nightly Qwen3-235B-disagg-pd
nightly command triggered.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Suggested PR Title:

[Attention][Misc] Refactor attention graph replay to remove UpdatableGraph and use standard NPUGraph

Suggested PR Summary:

### What this PR does / why we need it?
This PR refactors the attention graph replay mechanism by completely removing the custom `UpdatableGraph` implementation and replacing it with PyTorch's standard `torch.npu.NPUGraph`. The graph parameter update logic for both Paged Attention and Fused Infer Attention (FIA) has been consolidated directly into `AscendAttentionBackendImpl.update_graph_params`. This simplifies the codebase, removes redundant metadata update paths in speculative decoding proposers, and cleans up the `weak_ref_tensors` utility.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Tested with existing and updated unit tests in `tests/ut/attention/test_attention_v1.py` and `tests/ut/compilation/test_acl_graph.py`.

I have no further feedback to provide as there are no review comments.

@shiqiangA

shiqiangA commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator Author

/nightly Qwen3-235B-disagg-pd
nightly command triggered.

1 similar comment
@czydyy

czydyy commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

/nightly Qwen3-235B-disagg-pd
nightly command triggered.

@czydyy

czydyy commented Sep 21, 2026 •

Copy link
Copy Markdown
Collaborator

/nightly multi-node-qwen-disagg-pd
nightly command triggered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants