Skip to content

[CI] Modify the test case name - #16155

Merged
wenjun91 merged 1 commit into
vllm-project:mainfrom
weixinAc:weekly
Sep 10, 2026
Merged

wenjun91 merged 1 commit into
vllm-project:mainfrom
weixinAc:weekly

Conversation

@weixinAc

@weixinAc weixinAc commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does / why we need it?

1.Qwen3.5-122B Use case:Container names are formed by concatenating test case names with other specific characters. Kubernetes restricts container names to a maximum of 64 characters. Overly long test case names cause Kubernetes scheduling failures. The current solution is to shorten the test case name length.
2.Qwen3.6-35B Use case: Modify the dataset configuration.

Does this PR introduce any user-facing change?

NO

How was this patch tested?

by the running the test

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses CI stability and configuration accuracy. It primarily focuses on shortening test case identifiers to comply with Kubernetes container naming constraints and corrects dataset paths for specific model benchmarks to ensure successful test execution.

Highlights

  • Test Case Name Optimization: Shortened test case names for Qwen3.5-122B configurations to prevent Kubernetes scheduling failures caused by character limits in generated container names.
  • Dataset Configuration Update: Updated dataset paths in the Qwen3.6-35B configuration to ensure correct data loading for performance benchmarks.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/configs/weekly_config.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request shortens the test case names for Qwen3.5-122B multi-node configurations to prevent potential Kubernetes scheduling issues and updates the dataset paths in the Qwen3.6-35B single-node configuration. The reviewer feedback correctly points out that the PR title and summary do not adhere to the repository's PR Summary Style Guide, providing a compliant suggestion.

@@ -1,4 +1,4 @@
test_name: "Qwen3.5-122B-A10B-w4a8-128k-1k-TPOT50-90-PD"
test_name: "Qwen3.5-122B-A10B-w4a8-128k-1k-PD"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The PR title and summary do not fully adhere to the repository's PR Summary Style Guide. Specifically, the PR title is missing the [Action] tag (e.g., [BugFix] or [Misc]), and the PR summary should be formatted as per the style guide instructions.

Here are the suggested PR Title and PR Summary:

Suggested PR Title:

[CI][BugFix] Modify the test case name and dataset configuration

Suggested PR Summary:

### What this PR does / why we need it?

1. **Qwen3.5-122B Use Case**: Shortens the test case names for Qwen3.5-122B multi-node configurations to prevent Kubernetes scheduling failures. Kubernetes restricts container names (which are formed by concatenating test case names with other characters) to a maximum of 64 characters.
2. **Qwen3.6-35B Use Case**: Corrects and updates the dataset paths in the Qwen3.6-35B single-node configuration to ensure correct dataset configurations are used during testing.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Tested by running the modified end-to-end weekly test cases.
References
  1. PR Title and Summary must follow the specified formats, with the PR Title containing [Branch][Module][Action] prefixes and the PR Summary containing specific markdown sections. (link)

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Signed-off-by: weixin <murongfengerxch@163.com>
@wenjun91

wenjun91 commented Sep 9, 2026 •

Copy link
Copy Markdown
Collaborator

/weekly Qwen3.5-122B-A10B-w4a8-128k-1k-PD Qwen3.5-122B-A10B-w4a8-16k-1k-PD Qwen3.6-35B-A3B-w4a8-A3
weekly command triggered.

@wenjun91

wenjun91 commented Sep 10, 2026 •

Copy link
Copy Markdown
Collaborator

/weekly Qwen3.5-122B-A10B-w4a8-128k-1k-PD Qwen3.5-122B-A10B-w4a8-16k-1k-PD Qwen3.6-35B-A3B-w4a8-A3
weekly command triggered.

@wenjun91

wenjun91 commented Sep 10, 2026 •

Copy link
Copy Markdown
Collaborator

/weekly Qwen3.5-122B-A10B-w4a8-16k-1k-PD Qwen3.5-122B-A10B-w4a8-A3
weekly command triggered.

@wenjun91
wenjun91 merged commit 9e39b9e into vllm-project:main Sep 10, 2026
13 checks passed
chen-commits pushed a commit to chen-commits/vllm-ascend that referenced this pull request Sep 10, 2026
### What this PR does / why we need it?
1.Qwen3.5-122B Use case:Container names are formed by concatenating test
case names with other specific characters. Kubernetes restricts
container names to a maximum of 64 characters. Overly long test case
names cause Kubernetes scheduling failures. The current solution is to
shorten the test case name length.
2.Qwen3.6-35B Use case: Modify the dataset configuration.

### Does this PR introduce _any_ user-facing change?
NO

### How was this patch tested?
by the running the test

- vLLM main:
vllm-project/vllm@b2f6858

Signed-off-by: weixin <murongfengerxch@163.com>
sunny-rain-63 pushed a commit to sunny-rain-63/vllm-ascend that referenced this pull request Sep 12, 2026
### What this PR does / why we need it?
1.Qwen3.5-122B Use case:Container names are formed by concatenating test
case names with other specific characters. Kubernetes restricts
container names to a maximum of 64 characters. Overly long test case
names cause Kubernetes scheduling failures. The current solution is to
shorten the test case name length.
2.Qwen3.6-35B Use case: Modify the dataset configuration.

### Does this PR introduce _any_ user-facing change?
NO

### How was this patch tested?
by the running the test

- vLLM main:
vllm-project/vllm@b2f6858

Signed-off-by: weixin <murongfengerxch@163.com>
johnnysluckydays pushed a commit to johnnysluckydays/vllm-ascend that referenced this pull request Sep 14, 2026
### What this PR does / why we need it?
1.Qwen3.5-122B Use case:Container names are formed by concatenating test
case names with other specific characters. Kubernetes restricts
container names to a maximum of 64 characters. Overly long test case
names cause Kubernetes scheduling failures. The current solution is to
shorten the test case name length.
2.Qwen3.6-35B Use case: Modify the dataset configuration.

### Does this PR introduce _any_ user-facing change?
NO

### How was this patch tested?
by the running the test

- vLLM main:
vllm-project/vllm@b2f6858

Signed-off-by: weixin <murongfengerxch@163.com>
Signed-off-by: tianming2009 <13246728590@163.com>
like-0517 pushed a commit to like-0517/vllm-ascend that referenced this pull request Sep 15, 2026
### What this PR does / why we need it?
1.Qwen3.5-122B Use case:Container names are formed by concatenating test
case names with other specific characters. Kubernetes restricts
container names to a maximum of 64 characters. Overly long test case
names cause Kubernetes scheduling failures. The current solution is to
shorten the test case name length.
2.Qwen3.6-35B Use case: Modify the dataset configuration.

### Does this PR introduce _any_ user-facing change?
NO

### How was this patch tested?
by the running the test

- vLLM main:
vllm-project/vllm@b2f6858

Signed-off-by: weixin <murongfengerxch@163.com>
Signed-off-by: like-0517 <ithwlike@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants