Repository navigation
[CI] Modify the test case name - #16155
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses CI stability and configuration accuracy. It primarily focuses on shortening test case identifiers to comply with Kubernetes container naming constraints and corrects dataset paths for specific model benchmarks to ensure successful test execution. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request shortens the test case names for Qwen3.5-122B multi-node configurations to prevent potential Kubernetes scheduling issues and updates the dataset paths in the Qwen3.6-35B single-node configuration. The reviewer feedback correctly points out that the PR title and summary do not adhere to the repository's PR Summary Style Guide, providing a compliant suggestion.
| @@ -1,4 +1,4 @@ | |||
| test_name: "Qwen3.5-122B-A10B-w4a8-128k-1k-TPOT50-90-PD" | |||
| test_name: "Qwen3.5-122B-A10B-w4a8-128k-1k-PD" | |||
There was a problem hiding this comment.
The PR title and summary do not fully adhere to the repository's PR Summary Style Guide. Specifically, the PR title is missing the [Action] tag (e.g., [BugFix] or [Misc]), and the PR summary should be formatted as per the style guide instructions.
Here are the suggested PR Title and PR Summary:
Suggested PR Title:
[CI][BugFix] Modify the test case name and dataset configurationSuggested PR Summary:
### What this PR does / why we need it?
1. **Qwen3.5-122B Use Case**: Shortens the test case names for Qwen3.5-122B multi-node configurations to prevent Kubernetes scheduling failures. Kubernetes restricts container names (which are formed by concatenating test case names with other characters) to a maximum of 64 characters.
2. **Qwen3.6-35B Use Case**: Corrects and updates the dataset paths in the Qwen3.6-35B single-node configuration to ensure correct dataset configurations are used during testing.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Tested by running the modified end-to-end weekly test cases.References
- PR Title and Summary must follow the specified formats, with the PR Title containing [Branch][Module][Action] prefixes and the PR Summary containing specific markdown sections. (link)
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Signed-off-by: weixin <murongfengerxch@163.com>
|
/weekly Qwen3.5-122B-A10B-w4a8-128k-1k-PD Qwen3.5-122B-A10B-w4a8-16k-1k-PD Qwen3.6-35B-A3B-w4a8-A3
|
|
/weekly Qwen3.5-122B-A10B-w4a8-128k-1k-PD Qwen3.5-122B-A10B-w4a8-16k-1k-PD Qwen3.6-35B-A3B-w4a8-A3
|
|
/weekly Qwen3.5-122B-A10B-w4a8-16k-1k-PD Qwen3.5-122B-A10B-w4a8-A3
|
### What this PR does / why we need it? 1.Qwen3.5-122B Use case:Container names are formed by concatenating test case names with other specific characters. Kubernetes restricts container names to a maximum of 64 characters. Overly long test case names cause Kubernetes scheduling failures. The current solution is to shorten the test case name length. 2.Qwen3.6-35B Use case: Modify the dataset configuration. ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? by the running the test - vLLM main: vllm-project/vllm@b2f6858 Signed-off-by: weixin <murongfengerxch@163.com>
### What this PR does / why we need it? 1.Qwen3.5-122B Use case:Container names are formed by concatenating test case names with other specific characters. Kubernetes restricts container names to a maximum of 64 characters. Overly long test case names cause Kubernetes scheduling failures. The current solution is to shorten the test case name length. 2.Qwen3.6-35B Use case: Modify the dataset configuration. ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? by the running the test - vLLM main: vllm-project/vllm@b2f6858 Signed-off-by: weixin <murongfengerxch@163.com>
### What this PR does / why we need it? 1.Qwen3.5-122B Use case:Container names are formed by concatenating test case names with other specific characters. Kubernetes restricts container names to a maximum of 64 characters. Overly long test case names cause Kubernetes scheduling failures. The current solution is to shorten the test case name length. 2.Qwen3.6-35B Use case: Modify the dataset configuration. ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? by the running the test - vLLM main: vllm-project/vllm@b2f6858 Signed-off-by: weixin <murongfengerxch@163.com> Signed-off-by: tianming2009 <13246728590@163.com>
### What this PR does / why we need it? 1.Qwen3.5-122B Use case:Container names are formed by concatenating test case names with other specific characters. Kubernetes restricts container names to a maximum of 64 characters. Overly long test case names cause Kubernetes scheduling failures. The current solution is to shorten the test case name length. 2.Qwen3.6-35B Use case: Modify the dataset configuration. ### Does this PR introduce _any_ user-facing change? NO ### How was this patch tested? by the running the test - vLLM main: vllm-project/vllm@b2f6858 Signed-off-by: weixin <murongfengerxch@163.com> Signed-off-by: like-0517 <ithwlike@126.com>
What this PR does / why we need it?
1.Qwen3.5-122B Use case:Container names are formed by concatenating test case names with other specific characters. Kubernetes restricts container names to a maximum of 64 characters. Overly long test case names cause Kubernetes scheduling failures. The current solution is to shorten the test case name length.
2.Qwen3.6-35B Use case: Modify the dataset configuration.
Does this PR introduce any user-facing change?
NO
How was this patch tested?
by the running the test