[BugFix][CI] Build with oci-mediatypes=false to produce Docker manifest list for SWR by JavaPythonAIForBAT · Pull Request #16130 · vllm-project/vllm-ascend

JavaPythonAIForBAT · 2026-09-09T06:53:39Z

What this PR does / why we need it?

SWR rejects OCI image index (application/vnd.oci.image.index.v1+json) produced by docker buildx imagetools create when merging OCI-format single-arch images, returning 400 Bad Request: Invalid image, fail to parse 'manifest.json'.

Root cause: docker buildx imagetools create selects the output media type based on the source manifests. When all sources are Docker v2 schema2 (application/vnd.docker.*), it produces a Docker manifest list (application/vnd.docker.distribution.manifest.list.v2+json) which SWR accepts. With OCI sources it produces an OCI image index, which SWR rejects.

Fix: add oci-mediatypes=false to the build output so single-arch images are built as Docker v2 schema2. This lets docker buildx imagetools create produce a Docker manifest list directly, and eliminates the skopeo-based format conversion entirely (which required sudo/root not available on the self-hosted runner).

Changes

Build output: add oci-mediatypes=false
build-push-digest "Tag digest to prevent GC": replace skopeo copy with docker buildx imagetools create
merge-image: replace skopeo copy + docker manifest create/push with direct docker buildx imagetools create
merge-image-temp: same as merge-image
"Clean up temp tags" (both jobs): remove sudo apt-get install skopeo; guard skopeo delete with a command -v check so the job no longer fails when skopeo is unavailable

Does this PR introduce any user-facing change?

No. Only the CI image build/push workflow is changed.

How was this patch tested?

CI workflow changes verified locally (YAML valid, job structure intact)
No skopeo/sudo/apt-get dependencies remain in the merge path, so the previous skopeo: command not found failure on the self-hosted (non-root, no-sudo) runner is eliminated
vLLM main: vllm-project/vllm@b2f6858

github-actions · 2026-09-09T06:54:41Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

gemini-code-assist · 2026-09-09T06:55:07Z

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

github-actions · 2026-09-09T06:55:15Z

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

A PR should do only one thing, smaller PRs enable faster reviews.
Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Tip

💡 Consider Linking a Related Issue or RFC

Your PR title contains the [BugFix] tag, indicating a bug fix or new feature.

Linking a related issue or RFC in the PR description is strongly encouraged — it gives reviewers helpful context and speeds up the review. You can use any of these keywords:

Fixes #<issue_number>
Closes #<issue_number>
Resolves #<issue_number>
Refs #<rfc_or_issue_number> (for RFCs)

🙏 Thanks for helping us keep the project well-organized!

…ist for SWR SWR rejects OCI image index (application/vnd.oci.image.index.v1+json) produced by 'docker buildx imagetools create' when combining OCI-format single-arch images, returning 400 Bad Request 'Invalid image, fail to parse manifest.json'. Root cause: buildx imagetools create selects output media type based on source manifests. When all sources are Docker v2 schema2, it produces a Docker manifest list (application/vnd.docker.distribution.manifest.list.v2+json) which SWR accepts. With OCI sources, it produces OCI image index which SWR rejects. Fix: add oci-mediatypes=false to the build output, so single-arch images are built as Docker v2 schema2. This allows docker buildx imagetools create to produce a Docker manifest list directly, eliminating the need for skopeo-based format conversion (which required sudo/root not available on the self-hosted runner). Changes: - Build output: add oci-mediatypes=false - build-push-digest 'Tag digest to prevent GC': replace skopeo copy with docker buildx imagetools create - merge-image: replace skopeo copy + docker manifest create/push with direct docker buildx imagetools create - merge-image-temp: same as merge-image - All 'Clean up temp tags': remove sudo apt-get install skopeo, guard skopeo delete with command -v check (no hard failure if unavailable) Signed-off-by: JavaPythonAIForBAT <wuhejun@h-partners.com>

The schedule_tag_pattern was hardcoded to 'main' in the parent workflow (schedule_image_build_and_push.yaml:161), so the final image tag was always 'nightly-main-<suffix>-<digest>' regardless of the branch/tag passed via workflow_dispatch. Add a 'Prepare tag pattern' step in all three jobs (build-push-digest, merge-image, merge-image-temp) that dynamically computes the pattern: - Push tag / schedule events: use schedule_tag_pattern default ('main') - workflow_dispatch with tag: use the tag itself - workflow_dispatch with branch: use branch_ref with '/' replaced by '-' All references to inputs.schedule_tag_pattern in tag generation, Docker meta, GC temp tags, and cleanup are updated to use the dynamic steps.tag_pattern.outputs.pattern. Signed-off-by: JavaPythonAIForBAT <wuhejun@h-partners.com>

When a pull_request with the image-build label runs the image build, image_build succeeds (build without push), which incorrectly triggers the trigger-image-sync job to dispatch the quay.io sync. Add github.event_name != 'pull_request' so sync only fires for non-PR events (push tag, branch/main push, workflow_dispatch, schedule), matching the intended behavior of syncing only after merge to main. Signed-off-by: JavaPythonAIForBAT <wuhejun@h-partners.com>

… SWR compatibility Replace the skopeo workaround (skopeo copy --format v2s2 + docker manifest create/push) with the proper fix: add oci-mediatypes=false to build output so docker buildx imagetools create produces a Docker manifest list instead of an OCI image index, which is accepted by SWR. Changes: - Add oci-mediatypes=false to build output - Replace all skopeo copy + docker manifest create/push with docker buildx imagetools create in merge and temp tag steps - Guard skopeo delete in cleanup with command -v check (no sudo needed) This is the same fix as PR vllm-project#16130. Signed-off-by: JavaPythonAIForBAT <wuhejun@h-partners.com>

…st list for SWR (vllm-project#16130) ## What this PR does / why we need it? SWR rejects OCI image index (`application/vnd.oci.image.index.v1+json`) produced by `docker buildx imagetools create` when merging OCI-format single-arch images, returning `400 Bad Request: Invalid image, fail to parse 'manifest.json'`. **Root cause**: `docker buildx imagetools create` selects the output media type based on the source manifests. When all sources are Docker v2 schema2 (`application/vnd.docker.*`), it produces a **Docker manifest list** (`application/vnd.docker.distribution.manifest.list.v2+json`) which SWR accepts. With OCI sources it produces an OCI image index, which SWR rejects. **Fix**: add `oci-mediatypes=false` to the build output so single-arch images are built as Docker v2 schema2. This lets `docker buildx imagetools create` produce a Docker manifest list directly, and eliminates the skopeo-based format conversion entirely (which required `sudo`/root not available on the self-hosted runner). ### Changes - **Build output**: add `oci-mediatypes=false` - **build-push-digest "Tag digest to prevent GC"**: replace `skopeo copy` with `docker buildx imagetools create` - **merge-image**: replace `skopeo copy` + `docker manifest create/push` with direct `docker buildx imagetools create` - **merge-image-temp**: same as merge-image - **"Clean up temp tags"** (both jobs): remove `sudo apt-get install skopeo`; guard `skopeo delete` with a `command -v` check so the job no longer fails when skopeo is unavailable ## Does this PR introduce any user-facing change? No. Only the CI image build/push workflow is changed. ## How was this patch tested? - CI workflow changes verified locally (YAML valid, job structure intact) - No skopeo/sudo/apt-get dependencies remain in the merge path, so the previous `skopeo: command not found` failure on the self-hosted (non-root, no-sudo) runner is eliminated - vLLM main: vllm-project/vllm@b2f6858 --------- Signed-off-by: JavaPythonAIForBAT <wuhejun@h-partners.com>

…st list for SWR (vllm-project#16130) ## What this PR does / why we need it? SWR rejects OCI image index (`application/vnd.oci.image.index.v1+json`) produced by `docker buildx imagetools create` when merging OCI-format single-arch images, returning `400 Bad Request: Invalid image, fail to parse 'manifest.json'`. **Root cause**: `docker buildx imagetools create` selects the output media type based on the source manifests. When all sources are Docker v2 schema2 (`application/vnd.docker.*`), it produces a **Docker manifest list** (`application/vnd.docker.distribution.manifest.list.v2+json`) which SWR accepts. With OCI sources it produces an OCI image index, which SWR rejects. **Fix**: add `oci-mediatypes=false` to the build output so single-arch images are built as Docker v2 schema2. This lets `docker buildx imagetools create` produce a Docker manifest list directly, and eliminates the skopeo-based format conversion entirely (which required `sudo`/root not available on the self-hosted runner). ### Changes - **Build output**: add `oci-mediatypes=false` - **build-push-digest "Tag digest to prevent GC"**: replace `skopeo copy` with `docker buildx imagetools create` - **merge-image**: replace `skopeo copy` + `docker manifest create/push` with direct `docker buildx imagetools create` - **merge-image-temp**: same as merge-image - **"Clean up temp tags"** (both jobs): remove `sudo apt-get install skopeo`; guard `skopeo delete` with a `command -v` check so the job no longer fails when skopeo is unavailable ## Does this PR introduce any user-facing change? No. Only the CI image build/push workflow is changed. ## How was this patch tested? - CI workflow changes verified locally (YAML valid, job structure intact) - No skopeo/sudo/apt-get dependencies remain in the merge path, so the previous `skopeo: command not found` failure on the self-hosted (non-root, no-sudo) runner is eliminated - vLLM main: vllm-project/vllm@b2f6858 --------- Signed-off-by: JavaPythonAIForBAT <wuhejun@h-partners.com> Signed-off-by: tianming2009 <13246728590@163.com>

…st list for SWR (vllm-project#16130) ## What this PR does / why we need it? SWR rejects OCI image index (`application/vnd.oci.image.index.v1+json`) produced by `docker buildx imagetools create` when merging OCI-format single-arch images, returning `400 Bad Request: Invalid image, fail to parse 'manifest.json'`. **Root cause**: `docker buildx imagetools create` selects the output media type based on the source manifests. When all sources are Docker v2 schema2 (`application/vnd.docker.*`), it produces a **Docker manifest list** (`application/vnd.docker.distribution.manifest.list.v2+json`) which SWR accepts. With OCI sources it produces an OCI image index, which SWR rejects. **Fix**: add `oci-mediatypes=false` to the build output so single-arch images are built as Docker v2 schema2. This lets `docker buildx imagetools create` produce a Docker manifest list directly, and eliminates the skopeo-based format conversion entirely (which required `sudo`/root not available on the self-hosted runner). ### Changes - **Build output**: add `oci-mediatypes=false` - **build-push-digest "Tag digest to prevent GC"**: replace `skopeo copy` with `docker buildx imagetools create` - **merge-image**: replace `skopeo copy` + `docker manifest create/push` with direct `docker buildx imagetools create` - **merge-image-temp**: same as merge-image - **"Clean up temp tags"** (both jobs): remove `sudo apt-get install skopeo`; guard `skopeo delete` with a `command -v` check so the job no longer fails when skopeo is unavailable ## Does this PR introduce any user-facing change? No. Only the CI image build/push workflow is changed. ## How was this patch tested? - CI workflow changes verified locally (YAML valid, job structure intact) - No skopeo/sudo/apt-get dependencies remain in the merge path, so the previous `skopeo: command not found` failure on the self-hosted (non-root, no-sudo) runner is eliminated - vLLM main: vllm-project/vllm@b2f6858 --------- Signed-off-by: JavaPythonAIForBAT <wuhejun@h-partners.com> Signed-off-by: like-0517 <ithwlike@126.com>

JavaPythonAIForBAT requested review from Yikun and wangxiyuan as code owners September 9, 2026 06:53

github-actions Bot added the merge-conflicts label Sep 9, 2026

github-actions Bot added the ci/build label Sep 9, 2026

JavaPythonAIForBAT added 2 commits September 9, 2026 16:25

JavaPythonAIForBAT force-pushed the fix/oci-manifest-format branch from ad98b73 to 896b869 Compare September 9, 2026 08:26

github-actions Bot removed the merge-conflicts label Sep 9, 2026

zhangxinyuehfad approved these changes Sep 10, 2026

View reviewed changes

wangxiyuan approved these changes Sep 10, 2026

View reviewed changes

wangxiyuan merged commit bdab8bd into vllm-project:main Sep 10, 2026
13 checks passed

Navigation Menu

Repository navigation

[BugFix][CI] Build with oci-mediatypes=false to produce Docker manifest list for SWR - #16130

[BugFix][CI] Build with oci-mediatypes=false to produce Docker manifest list for SWR#16130
wangxiyuan merged 3 commits into
vllm-project:mainfrom
JavaPythonAIForBAT:fix/oci-manifest-format

JavaPythonAIForBAT commented Sep 9, 2026 •

edited by github-actions Bot

Loading

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

gemini-code-assist Bot commented Sep 9, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026

💡 Consider Linking a Related Issue or RFC

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

JavaPythonAIForBAT commented Sep 9, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it?

Changes

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

github-actions Bot commented Sep 9, 2026

Uh oh!

gemini-code-assist Bot commented Sep 9, 2026

Uh oh!

github-actions Bot commented Sep 9, 2026

💡 Consider Linking a Related Issue or RFC

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JavaPythonAIForBAT commented Sep 9, 2026 •

edited by github-actions Bot

Loading