Repository navigation
[CI] fix a5 multi resource - #16107
Conversation
Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces flexibility into the CI pipeline's resource allocation configuration. By parameterizing the NPU resource name in the LWS job template, the system can now support different hardware environments, specifically enabling A5 multi-node nightly testing workflows. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
Suggested PR Title:
[Test][Misc] Parameterize NPU resource name in LWS templateSuggested PR Summary:
### What this PR does / why we need it?
This PR parameterizes the NPU resource name in the LWS template (`lws.yaml.jinja2`) using the `npu_resource_name` variable, defaulting to `huawei.com/ascend-1980`. This allows for more flexible configuration of NPU resources across different environments.
Feedback: The Jinja2 `default` filter should be updated to use `default(..., true)` to ensure that empty strings correctly fall back to the default values.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No tests were provided in this PR.| "{{ max_good_age_days | default("3") }}" | ||
| resources: | ||
| limits: | ||
| {{ npu_resource_name | default("huawei.com/ascend-1980") }}: {{ npu_per_node | default("16") }} |
There was a problem hiding this comment.
In Jinja2, the default filter only falls back to the default value if the variable is undefined. If npu_resource_name or npu_per_node are defined but passed as empty strings (e.g., ""), they will evaluate to empty strings, resulting in invalid YAML (e.g., an empty key or missing value under limits:). Passing true as the second argument to default ensures they fall back to their default values for empty strings or other falsy values.
{{ npu_resource_name | default("huawei.com/ascend-1980", true) }}: {{ npu_per_node | default("16", true) }}
| ephemeral-storage: 100Gi | ||
| huawei.com/ascend-1980: {{ npu_per_node | default("16") }} | ||
| requests: | ||
| {{ npu_resource_name | default("huawei.com/ascend-1980") }}: {{ npu_per_node | default("16") }} |
There was a problem hiding this comment.
In Jinja2, the default filter only falls back to the default value if the variable is undefined. If npu_resource_name or npu_per_node are defined but passed as empty strings (e.g., ""), they will evaluate to empty strings, resulting in invalid YAML (e.g., an empty key or missing value under requests:). Passing true as the second argument to default ensures they fall back to their default values for empty strings or other falsy values.
{{ npu_resource_name | default("huawei.com/ascend-1980", true) }}: {{ npu_per_node | default("16", true) }}
| "{{ max_good_age_days | default("3") }}" | ||
| resources: | ||
| limits: | ||
| {{ npu_resource_name | default("huawei.com/ascend-1980") }}: {{ npu_per_node | default("16") }} |
There was a problem hiding this comment.
In Jinja2, the default filter only falls back to the default value if the variable is undefined. If npu_resource_name or npu_per_node are defined but passed as empty strings (e.g., ""), they will evaluate to empty strings, resulting in invalid YAML (e.g., an empty key or missing value under limits:). Passing true as the second argument to default ensures they fall back to their default values for empty strings or other falsy values.
{{ npu_resource_name | default("huawei.com/ascend-1980", true) }}: {{ npu_per_node | default("16", true) }}
| ephemeral-storage: 100Gi | ||
| huawei.com/ascend-1980: {{ npu_per_node | default("16") }} | ||
| requests: | ||
| {{ npu_resource_name | default("huawei.com/ascend-1980") }}: {{ npu_per_node | default("16") }} |
There was a problem hiding this comment.
In Jinja2, the default filter only falls back to the default value if the variable is undefined. If npu_resource_name or npu_per_node are defined but passed as empty strings (e.g., ""), they will evaluate to empty strings, resulting in invalid YAML (e.g., an empty key or missing value under requests:). Passing true as the second argument to default ensures they fall back to their default values for empty strings or other falsy values.
{{ npu_resource_name | default("huawei.com/ascend-1980", true) }}: {{ npu_per_node | default("16", true) }}
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
|
Please add more description. |
|
/revert |
Revert of PR #16107 (merged onto `main`). Original PR: #16107 Original author: @xqchen7 Merge commit: `fed28d4ce692173954cb887284af45dfa2284a4d` --- ### What this PR does / why we need it? adapt resource got a5 multi nightly,add openlibing.secret parameter to enable a5 multi nightly run ### Does this PR introduce _any_ user-facing change? eable developer run a5 multi nightly ### How was this patch tested? - vLLM main: vllm-project/vllm@b2f6858 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
### What this PR does / why we need it? adapt resource got a5 multi nightly,add openlibing.secret parameter to enable a5 multi nightly run ### Does this PR introduce _any_ user-facing change? eable developer run a5 multi nightly ### How was this patch tested? - vLLM main: vllm-project/vllm@b2f6858 --------- Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
…lm-project#16387) Revert of PR vllm-project#16107 (merged onto `main`). Original PR: vllm-project#16107 Original author: @xqchen7 Merge commit: `fed28d4ce692173954cb887284af45dfa2284a4d` --- ### What this PR does / why we need it? adapt resource got a5 multi nightly,add openlibing.secret parameter to enable a5 multi nightly run ### Does this PR introduce _any_ user-facing change? eable developer run a5 multi nightly ### How was this patch tested? - vLLM main: vllm-project/vllm@b2f6858 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
### What this PR does / why we need it? adapt resource got a5 multi nightly,add openlibing.secret parameter to enable a5 multi nightly run ### Does this PR introduce _any_ user-facing change? eable developer run a5 multi nightly ### How was this patch tested? - vLLM main: vllm-project/vllm@b2f6858 --------- Signed-off-by: xqchen7 <chenxueqing7@huawei.com> Signed-off-by: tianming2009 <13246728590@163.com>
…lm-project#16387) Revert of PR vllm-project#16107 (merged onto `main`). Original PR: vllm-project#16107 Original author: @xqchen7 Merge commit: `fed28d4ce692173954cb887284af45dfa2284a4d` --- ### What this PR does / why we need it? adapt resource got a5 multi nightly,add openlibing.secret parameter to enable a5 multi nightly run ### Does this PR introduce _any_ user-facing change? eable developer run a5 multi nightly ### How was this patch tested? - vLLM main: vllm-project/vllm@b2f6858 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: tianming2009 <13246728590@163.com>
### What this PR does / why we need it? adapt resource got a5 multi nightly,add openlibing.secret parameter to enable a5 multi nightly run ### Does this PR introduce _any_ user-facing change? eable developer run a5 multi nightly ### How was this patch tested? - vLLM main: vllm-project/vllm@b2f6858 --------- Signed-off-by: xqchen7 <chenxueqing7@huawei.com> Signed-off-by: like-0517 <ithwlike@126.com>
…lm-project#16387) Revert of PR vllm-project#16107 (merged onto `main`). Original PR: vllm-project#16107 Original author: @xqchen7 Merge commit: `fed28d4ce692173954cb887284af45dfa2284a4d` --- ### What this PR does / why we need it? adapt resource got a5 multi nightly,add openlibing.secret parameter to enable a5 multi nightly run ### Does this PR introduce _any_ user-facing change? eable developer run a5 multi nightly ### How was this patch tested? - vLLM main: vllm-project/vllm@b2f6858 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: like-0517 <ithwlike@126.com>
What this PR does / why we need it?
adapt resource got a5 multi nightly,add openlibing.secret parameter to enable a5 multi nightly run
Does this PR introduce any user-facing change?
eable developer run a5 multi nightly
How was this patch tested?