Skip to content

[CI] fix a5 multi resource - #16107

Merged
wangxiyuan merged 7 commits into
vllm-project:mainfrom
xqchen7:a6_multi_909
Sep 11, 2026
Merged

wangxiyuan merged 7 commits into
vllm-project:mainfrom
xqchen7:a6_multi_909

Conversation

@xqchen7

@xqchen7 xqchen7 commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

What this PR does / why we need it?

adapt resource got a5 multi nightly,add openlibing.secret parameter to enable a5 multi nightly run

Does this PR introduce any user-facing change?

eable developer run a5 multi nightly

How was this patch tested?

Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces flexibility into the CI pipeline's resource allocation configuration. By parameterizing the NPU resource name in the LWS job template, the system can now support different hardware environments, specifically enabling A5 multi-node nightly testing workflows.

Highlights

  • Resource Configuration Flexibility: Updated the LWS configuration template to use a dynamic variable for the NPU resource name instead of a hardcoded value.
  • CI Compatibility: Enabled support for A5 multi-node nightly testing by allowing configurable resource naming.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Suggested PR Title:

[Test][Misc] Parameterize NPU resource name in LWS template

Suggested PR Summary:

### What this PR does / why we need it?
This PR parameterizes the NPU resource name in the LWS template (`lws.yaml.jinja2`) using the `npu_resource_name` variable, defaulting to `huawei.com/ascend-1980`. This allows for more flexible configuration of NPU resources across different environments.

Feedback: The Jinja2 `default` filter should be updated to use `default(..., true)` to ensure that empty strings correctly fall back to the default values.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
No tests were provided in this PR.

"{{ max_good_age_days | default("3") }}"
resources:
limits:
{{ npu_resource_name | default("huawei.com/ascend-1980") }}: {{ npu_per_node | default("16") }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In Jinja2, the default filter only falls back to the default value if the variable is undefined. If npu_resource_name or npu_per_node are defined but passed as empty strings (e.g., ""), they will evaluate to empty strings, resulting in invalid YAML (e.g., an empty key or missing value under limits:). Passing true as the second argument to default ensures they fall back to their default values for empty strings or other falsy values.

                {{ npu_resource_name | default("huawei.com/ascend-1980", true) }}: {{ npu_per_node | default("16", true) }}

ephemeral-storage: 100Gi
huawei.com/ascend-1980: {{ npu_per_node | default("16") }}
requests:
{{ npu_resource_name | default("huawei.com/ascend-1980") }}: {{ npu_per_node | default("16") }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In Jinja2, the default filter only falls back to the default value if the variable is undefined. If npu_resource_name or npu_per_node are defined but passed as empty strings (e.g., ""), they will evaluate to empty strings, resulting in invalid YAML (e.g., an empty key or missing value under requests:). Passing true as the second argument to default ensures they fall back to their default values for empty strings or other falsy values.

                {{ npu_resource_name | default("huawei.com/ascend-1980", true) }}: {{ npu_per_node | default("16", true) }}

"{{ max_good_age_days | default("3") }}"
resources:
limits:
{{ npu_resource_name | default("huawei.com/ascend-1980") }}: {{ npu_per_node | default("16") }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In Jinja2, the default filter only falls back to the default value if the variable is undefined. If npu_resource_name or npu_per_node are defined but passed as empty strings (e.g., ""), they will evaluate to empty strings, resulting in invalid YAML (e.g., an empty key or missing value under limits:). Passing true as the second argument to default ensures they fall back to their default values for empty strings or other falsy values.

                {{ npu_resource_name | default("huawei.com/ascend-1980", true) }}: {{ npu_per_node | default("16", true) }}

ephemeral-storage: 100Gi
huawei.com/ascend-1980: {{ npu_per_node | default("16") }}
requests:
{{ npu_resource_name | default("huawei.com/ascend-1980") }}: {{ npu_per_node | default("16") }}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

In Jinja2, the default filter only falls back to the default value if the variable is undefined. If npu_resource_name or npu_per_node are defined but passed as empty strings (e.g., ""), they will evaluate to empty strings, resulting in invalid YAML (e.g., an empty key or missing value under requests:). Passing true as the second argument to default ensures they fall back to their default values for empty strings or other falsy values.

                {{ npu_resource_name | default("huawei.com/ascend-1980", true) }}: {{ npu_per_node | default("16", true) }}

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
@lijiahang226

Copy link
Copy Markdown
Collaborator

Please add more description.

@lijiahang226 lijiahang226 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxiyuan
wangxiyuan merged commit fed28d4 into vllm-project:main Sep 11, 2026
13 checks passed
@zhangxinyuehfad

zhangxinyuehfad commented Sep 12, 2026 •

Copy link
Copy Markdown
Collaborator

/revert
[Bot]: revert completed successfully. New PR created: #16387

wenjun91 pushed a commit that referenced this pull request Sep 12, 2026
Revert of PR #16107 (merged onto `main`).

Original PR: #16107
Original author: @xqchen7
Merge commit: `fed28d4ce692173954cb887284af45dfa2284a4d`

---
### What this PR does / why we need it?
adapt resource got a5 multi nightly,add openlibing.secret parameter to
enable a5 multi nightly run

### Does this PR introduce _any_ user-facing change?
eable developer run a5 multi nightly

### How was this patch tested?


- vLLM main:
vllm-project/vllm@b2f6858

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sunny-rain-63 pushed a commit to sunny-rain-63/vllm-ascend that referenced this pull request Sep 12, 2026
### What this PR does / why we need it?
adapt resource got a5 multi nightly,add openlibing.secret parameter to
enable a5 multi nightly run

### Does this PR introduce _any_ user-facing change?
eable developer run a5 multi nightly

### How was this patch tested?

- vLLM main:
vllm-project/vllm@b2f6858

---------

Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
sunny-rain-63 pushed a commit to sunny-rain-63/vllm-ascend that referenced this pull request Sep 12, 2026
…lm-project#16387)

Revert of PR vllm-project#16107 (merged onto `main`).

Original PR: vllm-project#16107
Original author: @xqchen7
Merge commit: `fed28d4ce692173954cb887284af45dfa2284a4d`

---
### What this PR does / why we need it?
adapt resource got a5 multi nightly,add openlibing.secret parameter to
enable a5 multi nightly run

### Does this PR introduce _any_ user-facing change?
eable developer run a5 multi nightly

### How was this patch tested?


- vLLM main:
vllm-project/vllm@b2f6858

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
johnnysluckydays pushed a commit to johnnysluckydays/vllm-ascend that referenced this pull request Sep 14, 2026
### What this PR does / why we need it?
adapt resource got a5 multi nightly,add openlibing.secret parameter to
enable a5 multi nightly run

### Does this PR introduce _any_ user-facing change?
eable developer run a5 multi nightly

### How was this patch tested?

- vLLM main:
vllm-project/vllm@b2f6858

---------

Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
Signed-off-by: tianming2009 <13246728590@163.com>
johnnysluckydays pushed a commit to johnnysluckydays/vllm-ascend that referenced this pull request Sep 14, 2026
…lm-project#16387)

Revert of PR vllm-project#16107 (merged onto `main`).

Original PR: vllm-project#16107
Original author: @xqchen7
Merge commit: `fed28d4ce692173954cb887284af45dfa2284a4d`

---
### What this PR does / why we need it?
adapt resource got a5 multi nightly,add openlibing.secret parameter to
enable a5 multi nightly run

### Does this PR introduce _any_ user-facing change?
eable developer run a5 multi nightly

### How was this patch tested?


- vLLM main:
vllm-project/vllm@b2f6858

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: tianming2009 <13246728590@163.com>
like-0517 pushed a commit to like-0517/vllm-ascend that referenced this pull request Sep 15, 2026
### What this PR does / why we need it?
adapt resource got a5 multi nightly,add openlibing.secret parameter to
enable a5 multi nightly run

### Does this PR introduce _any_ user-facing change?
eable developer run a5 multi nightly

### How was this patch tested?

- vLLM main:
vllm-project/vllm@b2f6858

---------

Signed-off-by: xqchen7 <chenxueqing7@huawei.com>
Signed-off-by: like-0517 <ithwlike@126.com>
like-0517 pushed a commit to like-0517/vllm-ascend that referenced this pull request Sep 15, 2026
…lm-project#16387)

Revert of PR vllm-project#16107 (merged onto `main`).

Original PR: vllm-project#16107
Original author: @xqchen7
Merge commit: `fed28d4ce692173954cb887284af45dfa2284a4d`

---
### What this PR does / why we need it?
adapt resource got a5 multi nightly,add openlibing.secret parameter to
enable a5 multi nightly run

### Does this PR introduce _any_ user-facing change?
eable developer run a5 multi nightly

### How was this patch tested?

- vLLM main:
vllm-project/vllm@b2f6858

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: like-0517 <ithwlike@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants