Repository navigation
[Doc][Misc] Complete SP MoE guide and temporary FlashComm switch #15737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
realliujiaxu
merged 9 commits into
vllm-project:main
from
MmMmaru:agent/sequence-parallelism-doc
Sep 10, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4a32321
docs: document SP MoE and temporary FlashComm switch
MmMmaru 187f0c4
docs: translate register_custom_ops comments to English
MmMmaru 4cfe73e
docs: explain SP MoE principle
MmMmaru c21d488
docs: use English for SP MoE principle
MmMmaru fecf35d
doc: update SP docs
MmMmaru 753cde5
doc: update deperated flashcomm and setup
MmMmaru e85b337
docs: fix markdownlint issues in sequence parallelism guide
MmMmaru b633f7d
doc: update doc
MmMmaru be290cf
doc: update doc
MmMmaru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The attention
o_projis a RowParallelLinear layer. Its inputs are sharded across TP ranks, and its outputs are all-reduced (replicated) across TP ranks. Therefore, the inputs to the subsequent MoE layer (which are the outputs ofo_proj) are replicated on every TP rank. Saying thato_proj's inputs are replicated is technically incorrect and confusing.\n\nSuggested PR Title:\n\nmarkdown\n[Doc][Misc] Complete SP MoE guide and temporary FlashComm switch\n\n\nSuggested PR Summary:\n\nmarkdown\n### What this PR does / why we need it?\n\nCompletes the `sequence_parallelism.md` feature guide, which currently only has\nan Overview skeleton plus a stale \"FlashComm is deprecated\" note. The new content\ncovers SP MoE end to end:\n\n- Principle: upstream `ParallelConfig.use_sequence_parallel_moe` activation\n conditions (TP>1, DP>1, `enable_expert_parallel`, SP-capable `all2all_backend`),\n the per-layer EP all-gather/unpad -> MoE -> pad/reduce-scatter -> TP all-gather\n flow, and the compile-time (`pass_config.enable_sp`, `sp_min_token_num`,\n `enable_sp_by_pass`) / run-time (TP-aligned cudagraph sizes) behavior.\n- How to use: upstream serve flags, constraints (TP>1, EP required for MoE,\n TP-multiple capture sizes, PCP incompatibility).\n- The temporary Ascend-only FlashComm switch: by default the platform forces\n `all2all_backend=flashinfer_all2allv` (SP MoE off); setting\n `additional_config.enable_flashcomm1` (preferred) or\n `VLLM_ASCEND_ENABLE_FLASHCOMM1=1` opts into upstream SP MoE. Documents that the\n switch is temporary/deprecated and will be removed once SP is supported.\n\n### Does this PR introduce _any_ user-facing change?\n\nDocumentation only. No code behavior change.\n\n### How was this patch tested?\n\n- `markdownlint docs/source/user_guide/feature_guide/sequence_parallelism.md` passes.\n- No code changed, so no unit/e2e tests apply.\nReferences