[Test] Fix UT for EPLBController - #15283
Conversation
Signed-off-by: Spicy-Stick <873805887@qq.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the unit tests for the EPLBController to reflect recent changes in the controller's internal API. The tests now correctly validate the behavior of the prepare_forward method, ensuring that state recording and phase handling are functioning as expected under various conditions. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Code Review
This pull request updates the unit tests in tests/ut/worker/v2/test_eplb_controller.py to test the new prepare_forward interface instead of the deprecated step method. The reviewer feedback suggests updating the PR title and summary to comply with the repository's style guide format.
| ) | ||
|
|
||
| def test_nonmatching_phase_is_forwarded_as_dummy(self): | ||
| def test_prepare_forward_records_matching_phase(self): |
There was a problem hiding this comment.
According to the repository style guide, the PR title and summary should follow a specific format. Here are the suggested PR title and summary based on the style guide:
Suggested PR Title:
[Test][BugFix] Fix UT for EPLBControllerSuggested PR Summary:
### What this PR does / why we need it?
This PR updates the unit tests for `AscendEPLBController` to align with the new `prepare_forward` interface instead of the deprecated `step` method. This ensures that the unit tests correctly verify the load collection phase filtering and step recording behavior.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
The patch itself consists of unit test updates. The updated unit tests in `tests/ut/worker/v2/test_eplb_controller.py` were executed and passed.References
- The PR title and summary should follow the specified format in the repository style guide, including the [Branch][Module][Action] prefix for the title and the standard sections for the summary. (link)
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
### What this PR does / why we need it? This PR updates the unit tests for `AscendEPLBController` to align with the new `prepare_forward` interface instead of the deprecated `step` method. This ensures that the unit tests correctly verify the load collection phase filtering and step recording behavior. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? The patch itself consists of unit test updates. The updated unit tests in `tests/ut/worker/v2/test_eplb_controller.py` were executed and passed. - vLLM main: vllm-project/vllm@ba07e4a Signed-off-by: Spicy-Stick <873805887@qq.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
Restore pr_test.yaml exactly to upstream/main now that the main2main compatibility failures are resolved. The EPLB baseline test fix landed through vllm-ascend PR vllm-project#15283 (commit f1ab204). Signed-off-by: shenzhao <shenzhao9@huawei.com>
What this PR does / why we need it?
This PR updates the unit tests for
AscendEPLBControllerto align with the newprepare_forwardinterface instead of the deprecatedstepmethod. This ensures that the unit tests correctly verify the load collection phase filtering and step recording behavior.Does this PR introduce any user-facing change?
No.
How was this patch tested?
The patch itself consists of unit test updates. The updated unit tests in
tests/ut/worker/v2/test_eplb_controller.pywere executed and passed.