[ExternalDP][RL] Make external DP support on EP and ETP#1384
Closed
MengqingCao wants to merge 2 commits intovllm-project:mainfrom
Closed
[ExternalDP][RL] Make external DP support on EP and ETP#1384MengqingCao wants to merge 2 commits intovllm-project:mainfrom
MengqingCao wants to merge 2 commits intovllm-project:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1384 +/- ##
==========================================
- Coverage 27.39% 27.23% -0.16%
==========================================
Files 56 56
Lines 6191 6209 +18
==========================================
- Hits 1696 1691 -5
- Misses 4495 4518 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: MengqingCao <cmq0113@163.com>
Signed-off-by: MengqingCao <cmq0113@163.com>
83 tasks
Collaborator
Author
|
This is ready for review @Yikun @wangxiyuan @ganyi1996ppo |
Collaborator
Author
|
Will close after #1422 is backportted on main |
Collaborator
Author
|
closing as done in #1681 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Make external DP support on EP and ETP
fix #1396 #1154
How was this patch tested?
CI passed with new added test.