[Doc] Fix link errors and add section anchors - #13485
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the documentation quality by fixing broken or outdated links and adding consistent anchors to deployment sections. These changes ensure that users can reliably access external resources and navigate the documentation more effectively. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates several documentation files to fix broken links (such as the Docker installation guide and the msmodelslim quantization method link) and adds explicit section anchors ({: #5-online-service-deployment }) to the "5 Online Service Deployment" headers across multiple model tutorial files. The reviewer pointed out that the PR title and description do not follow the repository's Pull Request Summary Style Guide and provided a compliant template to use.
Signed-off-by: herizhen <1270637059@qq.com>
774141a to
5585f91
Compare
…into vllm-new # By shenhui-cli (8) and others # Via GitHub (1) and shenhui-cli (1) * 'vllm-new' of https://github.com/shenhui-cli/vllm-ascend: (34 commits) When the PR modifies any files in the CSRC folder, skip the test case filtering logic and execute all test cases by default. [MRV2][Bugfix] Fix two triton ops errors in model_runner_v2 num_nans_kernel and apply_panalties (vllm-project#13159) [Cherry-pick][main][Doc][BugFix] Update proxy script name in DeepSeek-V3.2 tutorial (from vllm-project#13537) (vllm-project#13575) [Refactor][quantization]remove mxfp_compat compatibility shim and inline dtype references (vllm-project#13447) [MTP][BugFix] Preserve MoE weight loaders during online updates (vllm-project#13337) [Feature][xlite] Support MLA and DSA (`DeepseekV3ForCausalLM`, `DeepseekV32ForCausalLM` and `GlmMoeDsaForCausalLM`) in the xlite adapter (vllm-project#13378) [BugFix][xlite] Fix DP metadata handling in XliteWrapper and pass down the max number of tokens across all DP ranks for collective communications. (vllm-project#11213) [Refactor][Ops] Move expert routing into router classes (vllm-project#13417) [Platform][Refactor] Refactor NPUPlatform for better organization and clarity (vllm-project#13484) [BugFix] fix fiaV2 contiguous err in GQA (vllm-project#13456) [feature][KV Offload] Support Sparse KV Cache Offload (vllm-project#13026) [Bugfix][MRV2]Skip D2H copy and synchronize when spec decode is not active (vllm-project#13382) [Bugfix] Change AscendSFAIndexerCacheSpec to inherit MLAAttentionSpec (vllm-project#12849) [BugFix][FusedMoE] Restore BF16 quant method initialization (vllm-project#13412) [Doc] Fix link errors and add section anchors (vllm-project#13485) [TEST]Revise the A3 case (vllm-project#13495) [CI] modify default cann_version and add build_type support in nightly (vllm-project#13480) [CI]Improve logging, optimize function-level recommendation algorithm, and add early exit for no product code changes (vllm-project#13472) This PR restricts the test case discovery scope to the following directories: tests/e2e/pull_request/ tests/ut/ This PR restricts the test case discovery scope to the following directories: tests/e2e/pull_request/ tests/ut/ ... # Conflicts: # .github/workflows/scripts/test_selector.py
### What this PR does / why we need it?
This PR fixes broken links in the documentation (such as the Docker
installation guide link and the `msmodelslim` quantization method link)
and adds explicit anchors (`{: vllm-project#5-online-service-deployment }`) to the
"5 Online Service Deployment" headers across various model tutorial
files to ensure correct cross-referencing.
### Does this PR introduce _any_ user-facing change?
No, this is a documentation-only update.
### How was this patch tested?
Verified that the links and anchors are correct.
- vLLM version: v0.26.0
- vLLM main:
vllm-project/vllm@0351e9a
Signed-off-by: herizhen <1270637059@qq.com>
### What this PR does / why we need it?
This PR fixes broken links in the documentation (such as the Docker
installation guide link and the `msmodelslim` quantization method link)
and adds explicit anchors (`{: vllm-project#5-online-service-deployment }`) to the
"5 Online Service Deployment" headers across various model tutorial
files to ensure correct cross-referencing.
### Does this PR introduce _any_ user-facing change?
No, this is a documentation-only update.
### How was this patch tested?
Verified that the links and anchors are correct.
- vLLM version: v0.26.0
- vLLM main:
vllm-project/vllm@0351e9a
Signed-off-by: herizhen <1270637059@qq.com>
### What this PR does / why we need it?
This PR fixes broken links in the documentation (such as the Docker
installation guide link and the `msmodelslim` quantization method link)
and adds explicit anchors (`{: vllm-project#5-online-service-deployment }`) to the
"5 Online Service Deployment" headers across various model tutorial
files to ensure correct cross-referencing.
### Does this PR introduce _any_ user-facing change?
No, this is a documentation-only update.
### How was this patch tested?
Verified that the links and anchors are correct.
- vLLM version: v0.26.0
- vLLM main:
vllm-project/vllm@0351e9a
Signed-off-by: herizhen <1270637059@qq.com>
What this PR does / why we need it?
This PR fixes broken links in the documentation (such as the Docker installation guide link and the
msmodelslimquantization method link) and adds explicit anchors ({: #5-online-service-deployment }) to the "5 Online Service Deployment" headers across various model tutorial files to ensure correct cross-referencing.Does this PR introduce any user-facing change?
No, this is a documentation-only update.
How was this patch tested?
Verified that the links and anchors are correct.