[DP] Add max_num_tokens_across_dp to AscendMetadata to fix dp and update example #1273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 18, 2025
MengqingCao
force-pushed
the
dp
branch
2 times, most recently
from
a79311f to
4b69066
Compare
Collaborator
Author
|
Not sure why CI time out now, try to increase timeout to fix p.s. the same test sucessed in v0.9.1 already |
29 tasks
github-actions
bot
added
the
documentation
wangxiyuan
approved these changes
Jun 20, 2025
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: MengqingCao <[email protected]>
github-actions
bot
added
merge-conflicts
and removed
merge-conflicts
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1273 +/- ##
==========================================
- Coverage 27.39% 27.37% -0.03%
==========================================
Files 56 56
Lines 6191 6185 -6
==========================================
- Hits 1696 1693 -3
+ Misses 4495 4492 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@wangxiyuan plz help merge this and then #1277 , thanks! |
Yikun
changed the title
weijinqian0
pushed a commit
to weijinqian0/vllm-ascend
that referenced
this pull request
Jun 30, 2025
### What this PR does / why we need it? Add `max_num_tokens_across_dp` to AscendMetadata to fix dp This pr fixes the bug introduced by vllm-project#1229, which add an arg `max_num_tokens_across_dp` when dp_size > 1. Signed-off-by: MengqingCao <[email protected]>
chopper0126
pushed a commit
to chopper0126/vllm-ascend
that referenced
this pull request
Oct 16, 2025
### What this PR does / why we need it? Add `max_num_tokens_across_dp` to AscendMetadata to fix dp This pr fixes the bug introduced by vllm-project#1229, which add an arg `max_num_tokens_across_dp` when dp_size > 1. Signed-off-by: MengqingCao <[email protected]>
Angazenn
pushed a commit
to Angazenn/vllm-ascend
that referenced
this pull request
Oct 21, 2025
### What this PR does / why we need it? Add `max_num_tokens_across_dp` to AscendMetadata to fix dp This pr fixes the bug introduced by vllm-project#1229, which add an arg `max_num_tokens_across_dp` when dp_size > 1. Signed-off-by: MengqingCao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Add
max_num_tokens_across_dpto AscendMetadata to fix dpThis pr fixes the bug introduced by #1229, which add an arg
max_num_tokens_across_dpwhen dp_size > 1.Does this PR introduce any user-facing change?
How was this patch tested?