Repository navigation
[Feature] Support layerwise KV pool for Qwen3.5 hybrid GDN+full_attention models #12711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ab384eb
feat(qwen3.5): support layerwise KV pool for hybrid GDN+full_attentio…
tyy0829 10a625b
test(gdn): stub NPU side-effects in layerwise KV compile test
tyy0829 793727f
fix(kv-transfer): order Mamba state copy after layer load
tyy0829 7bc67af
fix(kv-pool): only trim external hit for Eagle when it reaches the fi…
tyy0829 807a9cb
docs: explain the layerwise mamba-copy ordering in model_runner_v1
tyy0829 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -477,7 +477,7 @@ def wait_for_kv_layer_from_connector(layer_name: str): | |||||
|
|
||||||
| forward_context: ForwardContext = get_forward_context() | ||||||
| attn_metadata = forward_context.attn_metadata | ||||||
| if attn_metadata is None: | ||||||
| if attn_metadata is None or not connector.has_connector_metadata(): | ||||||
| return | ||||||
| # TODO: assert ascendMetadata | ||||||
| connector.wait_for_layer_load(layer_name) | ||||||
|
|
@@ -494,7 +494,7 @@ def maybe_save_kv_layer_to_connector( | |||||
|
|
||||||
| forward_context: ForwardContext = get_forward_context() | ||||||
| attn_metadata = forward_context.attn_metadata | ||||||
| if attn_metadata is None: | ||||||
| if attn_metadata is None or not connector.has_connector_metadata(): | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To prevent potential
Suggested change
|
||||||
| return | ||||||
| # TODO: assert ascendMetadata | ||||||
| connector.save_kv_layer(layer_name, kv_cache_layer, attn_metadata) | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To prevent potential
AttributeErrororTypeErrorifconnectorisNoneor does not implementhas_connector_metadata, we should defensively check ifconnectoris notNoneand has the attribute before calling it.