Skip to content

[Misc][Quantization] Remove kvcache quant weight related patches. - #12463

Merged
weijinqian0 merged 1 commit into
vllm-project:mainfrom
menogrey:delete_patch1
Jul 23, 2026
Merged

[Misc][Quantization] Remove kvcache quant weight related patches.#12463
weijinqian0 merged 1 commit into
vllm-project:mainfrom
menogrey:delete_patch1

Conversation

@menogrey

@menogrey menogrey commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it?

After vllm-project/vllm#43167 vllm-project/vllm#44589, we can remove our two patches about kvcache quant weight.

Does this PR introduce any user-facing change?

How was this patch tested?

@menogrey
menogrey requested a review from wangxiyuan as a code owner July 21, 2026 04:02
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the KV cache quantization weight loading process by replacing legacy monkey-patches with a structured WeightsMapper implementation. This change improves maintainability, reduces code complexity, and aligns the quantization configuration with standard vLLM patterns.

Highlights

  • Refactored KV Cache Mapping: Replaced the manual get_cache_scale method with a more flexible get_cache_scale_mapper in AscendModelSlimConfig to support dynamic mapping for C8, FA, and Indexer quantization.
  • Removal of Legacy Patches: Deleted patch_gqa_c8.py and patch_weight_utils.py, cleaning up technical debt and removing reliance on monkey-patching for weight loading.
  • Improved Test Coverage: Added comprehensive unit tests in test_modelslim_config.py to verify the new mapper logic across different quantization configurations.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

Suggested PR Title:

[Ops][Misc] Refactor cache scale mapping to use WeightsMapper and remove obsolete patches

Suggested PR Summary:

### What this PR does / why we need it?
This PR refactors the cache scale mapping mechanism in `AscendModelSlimConfig` by replacing the custom `get_cache_scale` method with `get_cache_scale_mapper()`, which returns a `WeightsMapper`. This aligns with upstream vLLM's design.
As a result, the custom patches `patch_weight_utils.py` and `patch_gqa_c8.py` (which were previously used to intercept and remap C8/FA/indexer quantization scales) are no longer needed and have been removed.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Added unit tests in `tests/ut/quantization/test_modelslim_config.py` covering:
- Default mapper behavior
- C8 KV cache type mapper
- FA quantization mapper
- Indexer quantization mapper

I have no additional feedback to provide as there are no review comments.

Signed-off-by: menogrey <1299267905@qq.com>
@menogrey menogrey changed the title [Quantization] Remove kvcache quant weight related patches. [Misc][Quantization] Remove kvcache quant weight related patches. Jul 21, 2026
@menogrey menogrey added the ready enable e2e test for PR label Jul 21, 2026
@menogrey

menogrey commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

/rerun
[Bot]: rerun completed.

Rerun:

  • E2E

@menogrey

menogrey commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator Author

/weekly multi-node-glm4.7-w8a8c8-layerwise
weekly command triggered.

@weijinqian0
weijinqian0 merged commit 86923ba into vllm-project:main Jul 23, 2026
71 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants