[Misc] fix ci error - #11607
Conversation
Signed-off-by: wangkunpeng <1289706727@qq.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a CI error by modifying the cache scale mapper logic in the Ascend model configuration. The change ensures that the mapper correctly integrates with the base quantization configuration, improving consistency in how cache scales are handled. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. Tip 💡 Consider Linking a Related Issue or RFCYour PR title contains the [BugFix] tag, indicating a bug fix or new feature. Linking a related issue or RFC in the PR description is strongly encouraged — it gives reviewers helpful context and speeds up the review. You can use any of these keywords:
🙏 Thanks for helping us keep the project well-organized! |
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Signed-off-by: wangkunpeng <1289706727@qq.com>
Signed-off-by: wangkunpeng <1289706727@qq.com>
|
My #11053 introduce a CI error, it only test with last week's main branch locally, after vllm-ascend main2main update, vllm-project/vllm#44589 change the |
|
/rerun Rerun:
|
What this PR does / why we need it?
fix
AttributeError: 'NoneType' object has no attribute 'orig_to_new_renamings'The behavior of the
get_cache_scale_mappermethod is inconsistent between the0.23.0branch and themainbranch. Therefore, the method needs to be adapted separately.Does this PR introduce any user-facing change?
no
How was this patch tested?