Skip to content

[Misc] fix ci error - #11607

Closed
kunpengW-code wants to merge 3 commits into
vllm-project:mainfrom
kunpengW-code:bugfix-0708
Closed

[Misc] fix ci error#11607
kunpengW-code wants to merge 3 commits into
vllm-project:mainfrom
kunpengW-code:bugfix-0708

Conversation

@kunpengW-code

@kunpengW-code kunpengW-code commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it?

fix AttributeError: 'NoneType' object has no attribute 'orig_to_new_renamings'
The behavior of the get_cache_scale_mapper method is inconsistent between the 0.23.0 branch and the main branch. Therefore, the method needs to be adapted separately.

Does this PR introduce any user-facing change?

no

How was this patch tested?

Signed-off-by: wangkunpeng <1289706727@qq.com>
@kunpengW-code
kunpengW-code requested a review from wangxiyuan as a code owner July 8, 2026 06:44
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a CI error by modifying the cache scale mapper logic in the Ascend model configuration. The change ensures that the mapper correctly integrates with the base quantization configuration, improving consistency in how cache scales are handled.

Highlights

  • Logic Update: Updated the cache scale mapper logic to merge with the base QuantizationConfig mapper instead of returning None when no suffix map is present.
  • Test Adjustment: Updated unit tests to reflect the new behavior where the cache scale mapper is expected to be present.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.


Tip

💡 Consider Linking a Related Issue or RFC

Your PR title contains the [BugFix] tag, indicating a bug fix or new feature.

Linking a related issue or RFC in the PR description is strongly encouraged — it gives reviewers helpful context and speeds up the review. You can use any of these keywords:

  • Fixes #<issue_number>
  • Closes #<issue_number>
  • Resolves #<issue_number>
  • Refs #<rfc_or_issue_number> (for RFCs)

🙏 Thanks for helping us keep the project well-organized!

@kunpengW-code kunpengW-code added the ready enable e2e test for PR label Jul 8, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

Gemini encountered an error creating the review. You can try again by commenting /gemini review.

Signed-off-by: wangkunpeng <1289706727@qq.com>
Signed-off-by: wangkunpeng <1289706727@qq.com>
@kunpengW-code kunpengW-code changed the title [Bugfix] fix ci error [Misc] fix ci error Jul 8, 2026
@menogrey

menogrey commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

My #11053 introduce a CI error, it only test with last week's main branch locally, after vllm-ascend main2main update, vllm-project/vllm#44589 change the QuantizationConfig.get_cache_scale_mapper(), this PR bring a compatibility between two versions (main commit which contain the 44589 and 0.23.0)

@kunpengW-code

kunpengW-code commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator Author

/rerun
[Bot]: rerun completed.

Rerun:

  • E2E

@kunpengW-code kunpengW-code removed the ready enable e2e test for PR label Jul 8, 2026
@kunpengW-code
kunpengW-code deleted the bugfix-0708 branch July 17, 2026 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants