Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ def get_chip_type() -> str:
elif "950" in chip_name:
assert npu_name
return (chip_name + "_" + npu_name).lower()
elif "a2g3" in chip_name.lower():
# A2 case: CH version of the HDK
return "ascend910b1"
Comment on lines +121 to +123

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The comment on line 122 refers to the "CH version of the HDK", but the PR description states that this change is specifically to adapt for the "overseas version of HDK A2G3". This contradiction is misleading and could cause confusion for future maintainers. Please update the comment to refer to the "overseas version" to align with the actual intent of this PR.


Following the Repository Style Guide (Pull Request Summary Style Guide), here are the suggested PR Title and PR Summary:

Suggested PR Title:

[Ops][BugFix] Adapt A2G3 for the overseas version of HDK

Suggested PR Summary:

### What this PR does / why we need it?

This PR adds support for automatically identifying the chip type on environments using the overseas version of HDK A2G3. When the chip name contains "a2g3", it correctly identifies and returns "ascend910b1" as the SOC version, ensuring that vLLM Ascend can be properly installed and run.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

The installation and operation of vLLM Ascend in the environment of the overseas version of HDK must be carried out. After self-verification confirms no issues, the results still need to be provided by the testers.
Suggested change
elif "a2g3" in chip_name.lower():
# A2 case: CH version of the HDK
return "ascend910b1"
elif "a2g3" in chip_name.lower():
# A2 case: overseas version of the HDK
return "ascend910b1"
References
  1. The PR Title and PR Summary must follow the specific format defined in the Repository Style Guide. (link)

else:
raise ValueError(f"Unable to recognize chip name: {chip_name}, please manually set env SOC_VERSION")
except subprocess.CalledProcessError as e:
Expand Down