[NPU] add tau bench example for npu - #297
Conversation
Signed-off-by: flb <floatlibai@gmail.com>
Documentation build overview
41 files changed ·
|
There was a problem hiding this comment.
Code Review
This pull request introduces a multi-turn tau-bench training example with trainable agents, custom rollout logic, tool-calling adapters, and execution scripts. It also refactors the vLLM rollout abort mechanism to use a direct /abort_requests endpoint, avoiding worker pause/resume cycles and potential deadlocks. Feedback on the changes highlights a fragile lexicographical string comparison in trainable_agents.py that should be replaced with a length-based check, a specification violation in openai_tool_adapter.py where the arguments field must be JSON-serialized, and a redundant try-except block around build_env that can be simplified.
43f8b6e to
662a676
Compare
662a676 to
9dc366b
Compare
Signed-off-by: flb <floatlibai@gmail.com>
9dc366b to
66cecbe
Compare
|
/lgtm |
| @@ -0,0 +1,148 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
If the .sh files are example scripts, I’d suggest keeping only one. The two scripts differ in many ways, so multiple variants could be derived from them. For example, the GPU version uses the --colocate flag, while the NPU one does not adopt that mode.
There was a problem hiding this comment.
Do you mean removing the GPU script and keeping only the NPU one?
There was a problem hiding this comment.
I would suggest keeping the NPU version.
There was a problem hiding this comment.
I would suggest keeping the NPU version.
done
| set -ex | ||
|
|
||
| export PYTHONUNBUFFERED=1 | ||
| export ASCEND_RT_VISIBLE_DEVICES=0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15 |
There was a problem hiding this comment.
I noticed that the test uses 8 GPUs, but here it is marked as 16. Could you please confirm whether the scripts are consistent (i.e., the same for both)?
There was a problem hiding this comment.
This example script also uses 8 NPUs. ASCEND_RT_VISIBLE_DEVICES is set to 0–15 just as a generic/common environment variable (not indicative of actual device usage).
Signed-off-by: flb <floatlibai@gmail.com>


This pr mainly does the following:
mainbranch to theascendbranch [Example] Add tau-bench multi-turn tool-use example #142 fix(examples/tau-bench): use RunConfig.agent_strategy in TAU_CONFIGS (slime #2101) #280Note: To use
dynamic-sampling-filter, you need to cherry-pick #296 first, otherwise rollout abort may cause a hang.vllm: 967c5c3bc38891f4465d3f4e99917ed837bb3833
vllm-ascend: 4fcffdae97aa13c2752350385bb04288951eb6b5