Skip to content

ci: gate e2e jobs on pre-commit success #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CalvinXKY merged 3 commits into from
May 27, 2026
Merged

ci: gate e2e jobs on pre-commit success #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e369419
ci: gate e2e jobs on pre-commit success
aoshen02 May 23, 2026
8d785e6
ci: switch to pre-commit/action and auto-comment fix steps on failure
aoshen02 May 23, 2026
b3c08b6
ci: drop pre-commit.yml changes; keep only the gate
aoshen02 May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion .github/workflows/pr-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,28 @@ concurrency:

jobs:

pre-commit:
name: Run pre-commit (gate)
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.10'

- name: Run pre-commit
uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1
with:
extra_args: --all-files --show-diff-on-failure --color=always


e2e-test-short:
needs: pre-commit

if: (github.event_name == 'workflow_dispatch') || (github.event.pull_request && contains(github.event.pull_request.labels.*.name, 'run-ci-short'))

Expand Down Expand Up @@ -109,6 +130,7 @@ jobs:


e2e-test-sglang-config:

@CalvinXKY CalvinXKY May 24, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are quite a few SGLang configurations in these two files. Can they be removed?

@aoshen02 aoshen02 May 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge pr 18 first and then it will be removed.

needs: pre-commit

if: (github.event_name == 'workflow_dispatch') || (github.event.pull_request && contains(github.event.pull_request.labels.*.name, 'run-ci-sglang-config'))

Expand Down Expand Up @@ -192,6 +214,7 @@ jobs:


e2e-test-megatron:
needs: pre-commit

if: (github.event_name == 'workflow_dispatch') || (github.event.pull_request && contains(github.event.pull_request.labels.*.name, 'run-ci-megatron'))

Expand Down Expand Up @@ -275,6 +298,7 @@ jobs:


e2e-test-precision:
needs: pre-commit

if: (github.event_name == 'workflow_dispatch') || (github.event.pull_request && contains(github.event.pull_request.labels.*.name, 'run-ci-precision'))

Expand Down Expand Up @@ -358,6 +382,7 @@ jobs:


e2e-test-ckpt:
needs: pre-commit

if: (github.event_name == 'workflow_dispatch') || (github.event.pull_request && contains(github.event.pull_request.labels.*.name, 'run-ci-ckpt'))

Expand Down Expand Up @@ -441,6 +466,7 @@ jobs:


e2e-test-plugin-contracts:
needs: pre-commit

if: github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch'

Expand Down Expand Up @@ -506,6 +532,7 @@ jobs:


e2e-test-image:
needs: pre-commit

if: (github.event_name == 'workflow_dispatch') || (github.event.pull_request && contains(github.event.pull_request.labels.*.name, 'run-ci-image'))

Expand Down Expand Up @@ -590,6 +617,7 @@ jobs:


e2e-test-changed-detect:
needs: pre-commit
if: (github.event_name == 'workflow_dispatch') || (github.event.pull_request && contains(github.event.pull_request.labels.*.name, 'run-ci-changed'))
runs-on: self-hosted
outputs:
Expand Down Expand Up @@ -629,7 +657,7 @@ jobs:
fi

e2e-test-changed:
needs: e2e-test-changed-detect
needs: [pre-commit, e2e-test-changed-detect]
if: needs.e2e-test-changed-detect.outputs.has_tests == 'true'
runs-on: self-hosted
strategy:
Expand Down
24 changes: 23 additions & 1 deletion .github/workflows/pr-test.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,29 @@ concurrency:
cancel-in-progress: true

jobs:

pre-commit:
name: Run pre-commit (gate)
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: '3.10'

- name: Run pre-commit
uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1
with:
extra_args: --all-files --show-diff-on-failure --color=always

<% for job_name, config in jobs.items() %>
<< job_name >>:
needs: pre-commit
<% if config.get('always') %>
if: github.event_name == 'pull_request' || github.event_name == 'workflow_dispatch'
<% else %>
Expand Down Expand Up @@ -228,6 +249,7 @@ jobs:
<% endfor %>

e2e-test-changed-detect:
needs: pre-commit
if: (github.event_name == 'workflow_dispatch') || (github.event.pull_request && contains(github.event.pull_request.labels.*.name, 'run-ci-changed'))
runs-on: self-hosted
outputs:
Expand Down Expand Up @@ -267,7 +289,7 @@ jobs:
fi

e2e-test-changed:
needs: e2e-test-changed-detect
needs: [pre-commit, e2e-test-changed-detect]
if: needs.e2e-test-changed-detect.outputs.has_tests == 'true'
runs-on: self-hosted
strategy:
Expand Down
Loading