fix(test): align fanout_short assertion with #218 param changes - #226
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the expected call assertions in tests/test_qwen2.5_0.5B_fanout_short.py from 24 to 8, aligning with a change in rollout parameters. Additionally, it refactors the proxy environment variable cleanup to safely use a loop with os.environ.pop(..., None) to prevent potential KeyError exceptions if the variables are not set. There are no review comments, and I have no additional feedback to provide.
PR #218 changed num_rollout from 3→2 and rollout_batch_size from 8→4 but did not update the post-train assertion (expected 3*8=24, actual 2*4=8). Align with slime's upstream fix. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: aoshen02 <aoshen@inferact.ai>
aoshen02
force-pushed
the
fix/fanout-short-assertion
branch
from
June 10, 2026 02:40
0c99825 to
f0ca310
Compare
CalvinXKY
reviewed
Jun 10, 2026
CalvinXKY
left a comment
CalvinXKY
left a comment
Collaborator
There was a problem hiding this comment.
Currently, the CI is failing. Apart from machine-related issues, please confirm whether the CI meets the requirements; otherwise, merging is not recommended.
Collaborator
Author
|
This test will not pass without this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expected_calls = 3 * 8→2 * 4to match the num_rollout/rollout_batch_size values changed by PR fix: complete #1985 sync — remove TIGHT_HOST_MEMORY + align test params #218os.environ.pop("http_proxy")→os.environ.pop(proxy_var, None)to avoid KeyError when proxy env vars are not setTest plan
test_qwen2.5_0.5B_fanout_shortpasses with this fix (EXIT_RC=0)🤖 Generated with Claude Code