fix: trailing newlines + missing mimo --mtp-num-layers - #217
Closed
aoshen02 wants to merge 2 commits into
Closed
Conversation
#148 synced the coding_agent_rl subsystem (slime #1923 et al.) but missed the corresponding requirements: anthropic, e2b, openai, openai-agents. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Add POSIX-required trailing newline to 22 scripts/models/*.sh files - Restore `--mtp-num-layers 1` to scripts/models/mimo-7B-rl.sh (dropped during sync) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds several dependencies to requirements.txt (anthropic, e2b, openai, and openai-agents), introduces the --mtp-num-layers 1 argument to the mimo-7B-rl.sh model script, and standardizes file endings by adding missing trailing newlines across various model shell scripts. There are no review comments, and I have no feedback to provide.
Collaborator
Author
|
False positive: trailing newlines were an artifact of the diff pipeline (sed/echo adds a newline), slime originals also lack them. The mimo --mtp-num-layers was intentionally removed in #126. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/models/*.shfiles (missing in vime, present in slime)--mtp-num-layers 1toscripts/models/mimo-7B-rl.sh(dropped during sync)Test plan
🤖 Generated with Claude Code