fix(naming): remove gratuitous "vLLM" from neutral log strings (#18 OVER-translation) - #153
Merged
Merged
Conversation
aoshen02
added a commit
that referenced
this pull request
Jun 5, 2026
OVER-translation audit: slime #1953 logged the neutral "Error flushing cache:
HTTP …"; the vime port added "vLLM" ("Error resetting vLLM prefix cache: HTTP
…"). Remove the engine word to match slime's neutral wording (endpoint name
reset_prefix_cache is kept). The 4 pre-existing occurrences inherited from
main are fixed separately in PR #153.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
aoshen02
force-pushed
the
sync/over-translation-cleanup
branch
from
June 5, 2026 07:27
cf3939f to
ded50f3
Compare
aoshen02
added a commit
that referenced
this pull request
Jun 5, 2026
slime #1953 logged the neutral "Error flushing cache: HTTP …"; the port wrote "Error resetting vLLM prefix cache: HTTP …". Restore slime's exact wording (the /reset_prefix_cache endpoint + flush_cache method are vLLM's real API, unchanged). The 4 pre-existing main occurrences are fixed in PR #153. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
aoshen02
added a commit
that referenced
this pull request
Jun 5, 2026
slime #1953 logged the neutral "Error flushing cache: HTTP …"; the port wrote "Error resetting vLLM prefix cache: HTTP …". Restore slime's exact wording (the /reset_prefix_cache endpoint + flush_cache method are vLLM's real API, unchanged). The 4 pre-existing main occurrences are fixed in PR #153. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…VER-translation) Restore slime-verbatim neutral log wording where vime had over-translated by inserting "vLLM" into strings slime kept engine-agnostic: - "Shutdown vLLM engine" -> "Shutdown engine" - "Simulating crash on vLLM engine" -> "Simulating crash on engine" - "vLLM rollout: resuming workers..." -> "rollout: resuming workers..." - "Failed to resume vLLM worker" -> "Failed to resume worker" - "vLLM rollout abort (pause) for workers" -> "Abort request for %s" - "Failed to pause/abort worker" -> "Failed to abort worker at %s" flush_cache log strings dropped from this PR: #137 removes that retry loop entirely (vLLM /reset_prefix_cache always 200s), so there is nothing left to re-word there. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
aoshen02
force-pushed
the
sync/over-translation-cleanup
branch
from
June 5, 2026 14:04
ded50f3 to
1915152
Compare
princepride
marked this pull request as ready for review
June 6, 2026 08:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bidirectional translation audit, OVER direction: the original
#18sglang→vllm port injectedvLLMinto log/error strings where upstream slime was engine-neutral. Per the ground principle (vime = slime modulo sglang→vllm; never ADD an engine word where slime had none), restore neutrality.7 strings (4 in
vllm_engine.py, 3 invllm_rollout.py). Each verified 1:1 against slime@cutoff7a7aba4:Error resetting vLLM prefix cacheError flushing cacheTimeout while resetting vLLM prefix cacheTimeout while flushing cache.Shutdown vLLM engineShutdown engineSimulating crash on vLLM engineSimulating crash on enginevLLM rollout abort (pause)Abort request for …Failed to resume vLLM workerFailed to abort worker …vLLM rollout: resuming workers …Kept (not over-translation): vime-original vLLM machinery (IPC weight transfer,
/server_info, routing replay, MM placeholders, sleep/wake) and correct translations of slimeSGLang(e.g.Use external SGLang engine→vLLM).Translation rule reference:
agent_run/reports/SGLANG_TO_VLLM_TRANSLATION.md§1/§4.🤖 Generated with Claude Code