Repository navigation
Add VLM Geo3k multiturn experiment #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c30df68
Add vlm multiturn experiment.
andakai 372d6e0
update
andakai 95e89de
update
andakai de7ae5d
Fix multi-turn EOS offset handling in render prefix
andakai 2ca2d27
chore(geo3k): remove redundant latest_features assignment
andakai 7dfd9e8
enforce strict render-prefix alignment in geo3k rollout
andakai 175f2be
Simplify env construction call in geo3k multi-turn rollout
andakai ca939e2
Keep tool call score history fields while removing env-correct state
andakai 0696c9b
Merge origin/main into adk/vlm-multiturn
andakai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleanup (redundant state).
self.correctis only read immediately below at L249; it doesn't need to live on the env. A localcorrect = score == 1.0plusreturn obs, correct or is_final_turn, inforemoves the field and its init/reset at L42/L49.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix. This is truly redundant.