Closed
Conversation
Fix bug due to vllm-project/vllm#24278 Signed-off-by: Kyuyeun Kim <kyuyeunk@google.com>
DescriptionStart with a short description of what the PR does and how this is a change from The rest of the description includes relevant details and context, examples:
If the change fixes a bug or a Github issue, please include a link, e.g.,: TestsPlease describe how you tested this change, and include any instructions and/or ChecklistBefore submitting this PR, please make sure:
|
234eb29 to
acf6483
Compare
Collaborator
Author
|
Closing this as other PR that contains this fix got merged first: #715 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
vllm-project/vllm#24278 introduces argument
prompt_embedsto classNewRequestDatawith a default argumentNone: output.pyDue to this change, any new variable that is defined in a child class of
NewRequestData(e.g.,CachedRequestState) requires a default value.Otherwise, following error is thrown
Tests
https://buildkite.com/tpu-commons/tpu-commons-ci/builds/3153
Checklist
Before submitting this PR, please make sure: