Repository navigation
[CI] Fix vLLM integration CI (fp8 MoE, continue decode, routed-experts tests) - #3924
Merged
Merged
Conversation
Signed-off-by: Kewei Wang <keweiwang@google.com>
kwang3939
requested review from
a1yssan13,
gxd3,
jrplatin,
kyuyeunk,
mrjunwan-lang,
sixiang-google,
vanbasten23 and
wenxindongwork
as code owners
October 28, 2026 18:23
kwang3939
requested review from
CienetStingLin,
QiliangCui,
theminghuang,
yiw-wang and
yunyao-gg
as code owners
October 28, 2026 18:23
jrplatin
approved these changes
Oct 28, 2026
sixiang-google
approved these changes
Oct 28, 2026
DescriptionStart with a short description of what the PR does and how this is a change from The rest of the description includes relevant details and context, examples:
If the change fixes a Github issue, please include a link, e.g.,: TestsPlease describe how you tested this change, and include any instructions and/or ChecklistBefore submitting this PR, please make sure:
|
yiw-wang
approved these changes
Oct 28, 2026
kwang3939
enabled auto-merge (squash)
October 28, 2026 18:52
wenxindongwork
added a commit
that referenced
this pull request
Oct 29, 2026
…n engines on failure - Bump .buildkite/vllm_lkg.version 2fb320d8 -> 4541fcdd (vLLM main as of 2026-10-29 17:07 UTC). The fp8 MoE `per_act_token_quant` and continue-decode scheduler incompatibilities reported from tpu-vllm-integration build #151 were already fixed on main by #3924; today's integration build #157 (main + vLLM HEAD) passes the JAX unit tests and all Runai Model Streamer correctness tests, so this moves the pin forward to the current head. - tests/e2e/test_runai_model_streamer_loader.py: wrap generate() in try/finally so the engine core is always shut down. Previously a failure in the first LLM left its EngineCore process alive, and the second LLM in the same test then died with EngineDeadError, masking the real error. Signed-off-by: wenxindongwork <wenxindong@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes three breakages against upstream vLLM
HEAD:AttributeError(DeepSeek torchax E2E): vLLM #57092 readsself.per_act_token_quantinFp8MoEMethod.get_fused_moe_quant_config.VllmFp8MoEMethodreplaces vLLM's__init__, so the attribute was never set. Set it toFalse; the TPU kernels do not use the resulting quant config.test_sched_utils.py): vLLM #61589 movednum_output_placeholders -= Nand its assert fromAsyncSchedulerinto the baseScheduler, so it now runs before the patch's post-call compensation. Pre-compensate byN - 1before calling the base instead, which works on both LKG and HEAD. Also fix the test fixture so it does not pin the unpatched base ontoAsyncScheduler.test_routed_experts_slots.py): vLLM #62591 changedAuxOutputSchedulerConnector.__init__to take aKVCacheManager. Pass a minimal stub from the test helper. Test-only.Tests
Tested with:
Checklist
Before submitting this PR, please make sure: