Skip to content

Wrap get_model inside the vllm config context#1950

Merged
Lumosis merged 1 commit intomainfrom
lihao/oncall
Mar 18, 2026
Merged

Wrap get_model inside the vllm config context#1950
Lumosis merged 1 commit intomainfrom
lihao/oncall

Conversation

@Lumosis
Copy link
Collaborator

@Lumosis Lumosis commented Mar 18, 2026

Description

Fixed an error introduced by vllm-project/vllm#37136

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@Lumosis Lumosis self-assigned this Mar 18, 2026
@Lumosis Lumosis marked this pull request as ready for review March 18, 2026 04:16
@kyuyeunk kyuyeunk added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 18, 2026
@github-actions
Copy link

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a Github issue, please include a link, e.g.,:
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

Copy link
Collaborator

@QiliangCui QiliangCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the lkg to latest as well.

@Lumosis Lumosis force-pushed the lihao/oncall branch 4 times, most recently from f3a71d9 to b05f540 Compare March 18, 2026 19:47
@Lumosis Lumosis merged commit b336d01 into main Mar 18, 2026
46 checks passed
@Lumosis Lumosis deleted the lihao/oncall branch March 18, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants