Skip to content

[Multi Modal] Update multimodal_manager to align with vllm changes#1618

Merged
kwang3939 merged 1 commit intomainfrom
fix_mm_deprecation
Feb 4, 2026
Merged

[Multi Modal] Update multimodal_manager to align with vllm changes#1618
kwang3939 merged 1 commit intomainfrom
fix_mm_deprecation

Conversation

@kwang3939
Copy link
Copy Markdown
Collaborator

Description

gather_mm_placeholders and scatter_mm_placeholders are deprecated by vllm: vllm-project/vllm#33362.
Update the multimodal_manager to align with the changes.
Pin the vllm version right to this deprecation commit. There are some other errors when using the latest vllm version.

Tests

Tested locally with:

pytest -v -s tests/runner/test_multimodal_manager.py
bash tests/e2e/benchmarking/mm_bench.sh

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

Signed-off-by: Kewei Wang <keweiwang@google.com>
@kwang3939 kwang3939 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2026

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a Github issue, please include a link, e.g.,:
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@lk-chen lk-chen changed the title Update multimodal_manager to align with vllm changes [Multi Modal] Update multimodal_manager to align with vllm changes Feb 3, 2026
@kwang3939 kwang3939 merged commit 1581d97 into main Feb 4, 2026
30 of 31 checks passed
@kwang3939 kwang3939 deleted the fix_mm_deprecation branch February 4, 2026 01:22
patrickji2014 pushed a commit that referenced this pull request Feb 5, 2026
…1618)

Signed-off-by: Kewei Wang <keweiwang@google.com>
Signed-off-by: Patrick Ji <patrickji2014@gmail.com>
lorriexingfang pushed a commit to lorriexingfang/tpu-inference that referenced this pull request Feb 26, 2026
…llm-project#1618)

Signed-off-by: Kewei Wang <keweiwang@google.com>
Signed-off-by: Xing Fang <xing.fang@anyscale.com>
@kwang3939 kwang3939 mentioned this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants