[Multi Modal] Update multimodal_manager to align with vllm changes#1618
Merged
[Multi Modal] Update multimodal_manager to align with vllm changes#1618
Conversation
Signed-off-by: Kewei Wang <keweiwang@google.com>
DescriptionStart with a short description of what the PR does and how this is a change from The rest of the description includes relevant details and context, examples:
If the change fixes a Github issue, please include a link, e.g.,: TestsPlease describe how you tested this change, and include any instructions and/or ChecklistBefore submitting this PR, please make sure:
|
lk-chen
approved these changes
Feb 3, 2026
kyuyeunk
approved these changes
Feb 3, 2026
patrickji2014
pushed a commit
that referenced
this pull request
Feb 5, 2026
…1618) Signed-off-by: Kewei Wang <keweiwang@google.com> Signed-off-by: Patrick Ji <patrickji2014@gmail.com>
lorriexingfang
pushed a commit
to lorriexingfang/tpu-inference
that referenced
this pull request
Feb 26, 2026
…llm-project#1618) Signed-off-by: Kewei Wang <keweiwang@google.com> Signed-off-by: Xing Fang <xing.fang@anyscale.com>
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
gather_mm_placeholdersandscatter_mm_placeholdersare deprecated by vllm: vllm-project/vllm#33362.Update the
multimodal_managerto align with the changes.Pin the vllm version right to this deprecation commit. There are some other errors when using the latest vllm version.
Tests
Tested locally with:
Checklist
Before submitting this PR, please make sure: