Skip to content

[CI] Fix the MultiModalKwargsItem to align with vllm changes#1568

Merged
jcyang43 merged 1 commit intomainfrom
fix_mm_ci_unit_test
Jan 29, 2026
Merged

[CI] Fix the MultiModalKwargsItem to align with vllm changes#1568
jcyang43 merged 1 commit intomainfrom
fix_mm_ci_unit_test

Conversation

@kwang3939
Copy link
Copy Markdown
Collaborator

Description

Fix the CI failure caused by: vllm-project/vllm#33331.

Rm redundant logic on req_id in multimodal_manager.py.

Tests

Tested locally with pytest -v -s tests/runner/test_multimodal_manager.py, bash tests/e2e/benchmarking/mm_bench.sh.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

Signed-off-by: Kewei Wang <keweiwang@google.com>
@github-actions
Copy link
Copy Markdown

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a Github issue, please include a link, e.g.,:
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

@kwang3939 kwang3939 added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 29, 2026
Comment thread tpu_inference/runner/multimodal_manager.py
lk-chen added a commit that referenced this pull request Jan 29, 2026
Signed-off-by: Linkun Chen <github@lkchen.net>
@jcyang43 jcyang43 merged commit 61b412d into main Jan 29, 2026
27 of 31 checks passed
@lk-chen lk-chen mentioned this pull request Jan 29, 2026
1 task
@kwang3939 kwang3939 deleted the fix_mm_ci_unit_test branch January 29, 2026 22:17
lorriexingfang pushed a commit to lorriexingfang/tpu-inference that referenced this pull request Feb 26, 2026
…oject#1568)

Signed-off-by: Kewei Wang <keweiwang@google.com>
Signed-off-by: Xing Fang <xing.fang@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants